Skip to content

Commit 6497f20

Browse files
TylerHelmuthcparkins
authored andcommitted
[pkg/ottl] Fix bug where IsBool wasn't usable (open-telemetry#30151)
1 parent d3ce180 commit 6497f20

File tree

2 files changed

+39
-0
lines changed

2 files changed

+39
-0
lines changed
Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
# Use this changelog template to create an entry for release notes.
2+
3+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
4+
change_type: bug_fix
5+
6+
# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
7+
component: pkg/ottl
8+
9+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
10+
note: Fix bug where the Converter `IsBool` was not usable
11+
12+
# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
13+
issues: [30151]
14+
15+
# (Optional) One or more lines of additional information to render under the primary note.
16+
# These lines will be padded with 2 spaces and then inserted directly into the document.
17+
# Use pipe (|) for multiline entries.
18+
subtext:
19+
20+
# If your change doesn't affect end users or the exported elements of any package,
21+
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
22+
# Optional: The change log or logs in which this entry should be included.
23+
# e.g. '[user]' or '[user, api]'
24+
# Include 'user' if the change is relevant to end users.
25+
# Include 'api' if there is a change to a library API.
26+
# Default: '[user]'
27+
change_logs: []

pkg/ottl/functions.go

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -454,6 +454,18 @@ func (p *Parser[K]) buildArg(argVal value, argType reflect.Type) (any, error) {
454454
return nil, err
455455
}
456456
return StandardTimeGetter[K]{Getter: arg.Get}, nil
457+
case strings.HasPrefix(name, "BoolGetter"):
458+
arg, err := p.newGetter(argVal)
459+
if err != nil {
460+
return nil, err
461+
}
462+
return StandardBoolGetter[K]{Getter: arg.Get}, nil
463+
case strings.HasPrefix(name, "BoolLikeGetter"):
464+
arg, err := p.newGetter(argVal)
465+
if err != nil {
466+
return nil, err
467+
}
468+
return StandardBoolLikeGetter[K]{Getter: arg.Get}, nil
457469
case name == "Enum":
458470
arg, err := p.enumParser((*EnumSymbol)(argVal.Enum))
459471
if err != nil {

0 commit comments

Comments
 (0)