Merge pull request #21 from shervyna/flake8

add .flake file and fix flake8 errors

Author: priyaananthasankar

.flake8

@@ -0,0 +1,8 @@
+[flake8]
+# delete D100~D107 for docstring checks
+# W503 contradicts with pep8 and will soon be fixed by flake8
+ignore = W503, D100, D101, D102, D103, D104, D107
+max-line-length = 99
+exclude =
+    __pycache__,
+    azure/durable_functions/grpc/protobuf/

azure-pipelines.yml

@@ -32,7 +32,8 @@ steps:
   displayName: 'Autogenerate gRPC Python files'
 
 - script: |
-    flake8 . --count --show-source --statistics --exit-zero 
+    cd azure
+    flake8 . --count --show-source --statistics
   displayName: 'Run lint test with flake8'
 
 - script: |

azure/durable_functions/__init__.py

@@ -4,4 +4,4 @@
 __all__ = [
     'Orchestrator',
     'DurableOrchestrationClient'
-]
+]

azure/durable_functions/models/DurableOrchestrationClient.py

@@ -25,7 +25,8 @@ def __init__(self, context: str):
         self._showHistoryQueryKey: str = "showHistory"
         self._showHistoryOutputQueryKey: str = "showHistoryOutput"
         self._showInputQueryKey: str = "showInput"
-        self._orchestrationBindings: DurableOrchestrationBindings = DurableOrchestrationBindings(context)
+        self._orchestrationBindings: DurableOrchestrationBindings = \
+            DurableOrchestrationBindings(context)
 
     def start_new(self,
                   orchestration_function_name: str,
@@ -42,7 +43,8 @@ def get_json_input(client_input):
 
     def get_start_new_url(self, instance_id, orchestration_function_name):
         request_url = self._orchestrationBindings.creation_urls['createNewInstancePostUri']
-        request_url = request_url.replace(self._functionNamePlaceholder, orchestration_function_name)
+        request_url = request_url.replace(self._functionNamePlaceholder,
+                                          orchestration_function_name)
         request_url = request_url.replace(self._instanceIdPlaceholder,
                                           f'/{instance_id}' if instance_id is not None else '')
         return request_url

azure/durable_functions/models/OrchestratorState.py

@@ -1,6 +1,7 @@
 import json
 from typing import List, Any, Dict
-from .utils.json_utils import add_attrib, add_json_attrib
+from .utils.json_utils import add_attrib
+
 
 class OrchestratorState:
     def __init__(self,

azure/durable_functions/models/RetryOptions.py

@@ -15,6 +15,7 @@ def __init__(self, first_retry_interval_in_milliseconds: int, max_number_of_atte
     def to_json(self) -> Dict[str, Any]:
         json_dict = {}
 
-        add_attrib(json_dict, self, 'first_retry_interval_in_milliseconds', 'firstRetryIntervalInMilliseconds')
+        add_attrib(json_dict, self, 'first_retry_interval_in_milliseconds',
+                   'firstRetryIntervalInMilliseconds')
         add_attrib(json_dict, self, 'max_number_of_attempts', 'maxNumberOfAttempts')
         return json_dict

azure/durable_functions/models/actions/CallActivityAction.py

@@ -1,7 +1,7 @@
 from typing import Any, Dict
 
 from .ActionType import ActionType
-from ..utils.json_utils import add_attrib, add_json_attrib
+from ..utils.json_utils import add_attrib
 
 
 class CallActivityAction:

azure/durable_functions/models/history/HistoryEvent.py

@@ -1,4 +1,3 @@
-from datetime import datetime
 from .HistoryEventType import HistoryEventType
 
 

azure/durable_functions/models/history/__init__.py

@@ -4,4 +4,4 @@
 __all__ = [
     'HistoryEvent',
     'HistoryEventType'
-]
+]

azure/durable_functions/models/utils/json_utils.py

@@ -8,4 +8,4 @@ def add_attrib(json_dict: Dict[str, Any], object_, attribute_name: str, alt_name
 
 def add_json_attrib(json_dict: Dict[str, Any], object_, attribute_name: str, alt_name: str = None):
     if hasattr(object_, attribute_name):
-        json_dict[alt_name or attribute_name] = getattr(object_, attribute_name).to_json()
+        json_dict[alt_name or attribute_name] = getattr(object_, attribute_name).to_json()