Added validation for route name for http triggers (#1066)

* Validating route name

* Added unit tests

* Refactored unit tests

* Added check for function type

* Addressed comments

* changed function name

Co-authored-by: Gavin Aguiar <[email protected]>

Author: gavin-aguiar

azure_functions_worker/functions.py

@@ -78,6 +78,16 @@ def get_return_binding(binding_name: str,
 
         return return_binding_name
 
+    @staticmethod
+    def validate_binding_route(func_name: str, binding: BindingInfo,
+                               func_type: str):
+        if hasattr(binding, 'route') and binding.route.startswith(
+                '/') and func_type == 'function':
+            raise FunctionLoadError(
+                func_name,
+                f'Invalid route name: {binding.route}. Route name cannot begin'
+                f' with a /')
+
     @staticmethod
     def validate_binding_direction(binding_name: str,
                                    binding_direction: str,
@@ -93,6 +103,14 @@ def validate_binding_direction(binding_name: str,
                 func_name,
                 '"$return" binding must have direction set to "out"')
 
+    def validate_binding(self, func_name: str, binding: BindingInfo,
+                         func_type: str):
+        self.validate_binding_route(func_name, binding, func_type)
+
+        self.validate_binding_direction(binding.name,
+                                        binding.direction,
+                                        func_name)
+
     @staticmethod
     def is_context_required(params, bound_params: dict,
                             annotations: dict,
@@ -357,6 +375,7 @@ def add_indexed_function(self, function_id: str,
                              function):
         func = function.get_user_function()
         func_name = function.get_function_name()
+        func_type = function.http_type
         return_binding_name: typing.Optional[str] = None
         has_explicit_return = False
         has_implicit_return = False
@@ -368,9 +387,7 @@ def add_indexed_function(self, function_id: str,
 
         bound_params = {}
         for binding in function.get_bindings():
-            self.validate_binding_direction(binding.name,
-                                            binding.direction,
-                                            func_name)
+            self.validate_binding(func_name, binding, func_type)
 
             has_explicit_return, has_implicit_return = \
                 self.get_explicit_and_implicit_return(

tests/unittests/test_functions_registry.py

@@ -0,0 +1,49 @@
+# Copyright (c) Microsoft Corporation. All rights reserved.
+# Licensed under the MIT License.
+
+import unittest
+
+from azure.functions import Function
+from azure.functions.decorators.blob import BlobInput
+from azure.functions.decorators.http import HttpTrigger
+
+from azure_functions_worker import functions
+from azure_functions_worker.functions import FunctionLoadError
+
+
+class TestFunctionsRegistry(unittest.TestCase):
+
+    def setUp(self) -> None:
+        def dummy():
+            return "test"
+
+        self.dummy = dummy
+        self.func = Function(self.dummy, "test.py")
+        self.function_registry = functions.Registry()
+
+    def test_add_indexed_function_invalid_route(self):
+        trigger1 = HttpTrigger(name="req1", route="/")
+        self.func.add_trigger(trigger=trigger1)
+
+        with self.assertRaises(FunctionLoadError) as ex:
+            self.function_registry.add_indexed_function(function_id='123',
+                                                        function=self.func)
+
+        self.assertEqual(str(ex.exception),
+                         'cannot load the dummy function: Invalid route name: '
+                         '/. Route name cannot begin with a /')
+
+    def test_add_indexed_function_invalid_direction(self):
+        trigger1 = HttpTrigger(name="req1", route="test")
+        binding = BlobInput(name="$return", path="testpath",
+                            connection="testconnection")
+        self.func.add_trigger(trigger=trigger1)
+        self.func.add_binding(binding=binding)
+
+        with self.assertRaises(FunctionLoadError) as ex:
+            self.function_registry.add_indexed_function(function_id='123',
+                                                        function=self.func)
+
+        self.assertEqual(str(ex.exception),
+                         'cannot load the dummy function: \"$return\" '
+                         'binding must have direction set to \"out\"')