Skip to content

Commit 3a0e605

Browse files
committed
Adjust tox workflow for improved integration
This commit's changes are directly analogous to those in: EliahKagan/subaudit@353cd50 - Remove `fail-fast: false` to let failing checks cancel others. - Add a "collector" job that depends on all the jobs generated by the `tox` matrix job definition, so the individual jobs don't have to be added as required checks for branch protection. Instead, the name "All tox checks pass" has been added. This is based indirectly on the `test-pass` job in `gitoxide`, which was introduced in GitoxideLabs/gitoxide#1551 by https://github.com/NobodyXu. It is more specifically based on my adaptation of that in `algorithms-python` introduced in EliahKagan/algorithms-python#234. This is a common pattern, so it does not necessarily resemble the code in `gitoxide` more than it does that pattern elsewhere, and it is simpler than the version in `algorithms-python`. See: EliahKagan/algorithms-python@60d2d4e
1 parent 88ff1b1 commit 3a0e605

File tree

1 file changed

+15
-2
lines changed

1 file changed

+15
-2
lines changed

.github/workflows/tox.yml

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,6 @@ jobs:
4949
- python-version: '3.14'
5050
experimental: true
5151

52-
fail-fast: false
53-
5452
runs-on: ${{ matrix.os }}
5553

5654
defaults:
@@ -75,3 +73,18 @@ jobs:
7573

7674
- name: Check with tox
7775
run: tox --root ${{ matrix.package }}
76+
77+
all-pass:
78+
name: All tox checks pass
79+
80+
needs: [tox]
81+
82+
runs-on: ubuntu-latest
83+
84+
steps:
85+
- name: Some failed
86+
if: contains(needs.*.result, 'cancelled') || contains(needs.*.result, 'failure')
87+
run: false
88+
89+
- name: All passed
90+
run: true

0 commit comments

Comments
 (0)