zend_objects: Remove unnecessary refcounting when calling __clone()

TimWolla · TimWolla · commit 2e7332b4404c · 2025-07-16T09:12:41.000+02:00
Found as part of the clone-with review in php#18747.
diff --git a/Zend/zend_objects.c b/Zend/zend_objects.c
@@ -264,7 +264,6 @@ ZEND_API void ZEND_FASTCALL zend_objects_clone_members(zend_object *new_object,
 	}
 
 	if (has_clone_method) {
-		GC_ADDREF(new_object);
 		zend_call_known_instance_method_with_0_params(new_object->ce->clone, new_object, NULL);
 
 		if (ZEND_CLASS_HAS_READONLY_PROPS(new_object->ce)) {
@@ -274,8 +273,6 @@ ZEND_API void ZEND_FASTCALL zend_objects_clone_members(zend_object *new_object,
 				Z_PROP_FLAG_P(prop) &= ~IS_PROP_REINITABLE;
 			}
 		}
-
-		OBJ_RELEASE(new_object);
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -264,7 +264,6 @@ ZEND_API void ZEND_FASTCALL zend_objects_clone_members(zend_object *new_object,`
`264`	`264`	`}`
`265`	`265`
`266`	`266`	`if (has_clone_method) {`
`267`		`- GC_ADDREF(new_object);`
`268`	`267`	`zend_call_known_instance_method_with_0_params(new_object->ce->clone, new_object, NULL);`
`269`	`268`
`270`	`269`	`if (ZEND_CLASS_HAS_READONLY_PROPS(new_object->ce)) {`
`@@ -274,8 +273,6 @@ ZEND_API void ZEND_FASTCALL zend_objects_clone_members(zend_object *new_object,`
`274`	`273`	`Z_PROP_FLAG_P(prop) &= ~IS_PROP_REINITABLE;`
`275`	`274`	`}`
`276`	`275`	`}`
`277`		`-`
`278`		`- OBJ_RELEASE(new_object);`
`279`	`276`	`}`
`280`	`277`	`}`
`281`	`278`