fix(@angular/cli): resolve in all available node_modules

When @angular/cli dependencies (like @ngtool/webpack for example) are installed in its node_modules (as node_modules/@angular/cli/node_modules for example) webpack isn't seeing them.
By using a subset of the current `module.paths`, containing all the node_modules from the current file to the root, we always webpack to discover those modules.

Author: douglasduteil

packages/@angular/cli/custom-typings.d.ts

@@ -24,3 +24,8 @@ interface IWebpackDevServerConfigurationOptions {
   public?: string;
   disableHostCheck?: boolean;
 }
+
+
+interface NodeModule {
+  paths: string[];
+}

packages/@angular/cli/models/webpack-configs/common.ts

@@ -23,7 +23,8 @@ export function getCommonConfig(wco: WebpackConfigOptions) {
   const { projectRoot, buildOptions, appConfig } = wco;
 
   const appRoot = path.resolve(projectRoot, appConfig.root);
-  const nodeModules = path.resolve(projectRoot, 'node_modules');
+  const projectRootNodeModules = path.resolve(projectRoot, 'node_modules');
+  const nodeModules = module.paths.slice(0, module.paths.indexOf(projectRootNodeModules) + 1);
 
   let extraPlugins: any[] = [];
   let extraRules: any[] = [];
@@ -67,10 +68,10 @@ export function getCommonConfig(wco: WebpackConfigOptions) {
     devtool: buildOptions.sourcemaps ? 'source-map' : false,
     resolve: {
       extensions: ['.ts', '.js'],
-      modules: ['node_modules', nodeModules],
+      modules: [appRoot, 'node_modules', projectRootNodeModules],
     },
     resolveLoader: {
-      modules: [nodeModules]
+      modules: nodeModules
     },
     context: projectRoot,
     entry: entryPoints,
@@ -82,7 +83,7 @@ export function getCommonConfig(wco: WebpackConfigOptions) {
     },
     module: {
       rules: [
-        { enforce: 'pre', test: /\.js$/, loader: 'source-map-loader', exclude: [nodeModules] },
+        { enforce: 'pre', test: /\.js$/, loader: 'source-map-loader', exclude: nodeModules },
         { test: /\.json$/, loader: 'json-loader' },
         { test: /\.html$/, loader: 'raw-loader' },
         { test: /\.(eot|svg)$/, loader: `file-loader?name=[name]${hashFormat.file}.[ext]` },

tests/e2e/tests/misc/local-node_module.ts

@@ -0,0 +1,13 @@
+import { appendToFile, prependToFile } from '../../utils/fs';
+import { ng, silentNpm } from '../../utils/process';
+
+
+export default async function () {
+  await silentNpm('install', '[email protected]');
+
+  await prependToFile('src/app/app.module.ts', 'import * as firebase from \'firebase\';');
+  await appendToFile('src/app/app.module.ts', 'firebase.initializeApp({});');
+
+  await ng('build');
+  await ng('build', '--aot');
+}

tests/e2e/tests/misc/non-relative-module-resolution.ts

@@ -0,0 +1,21 @@
+import { prependToFile, writeMultipleFiles } from '../../utils/fs';
+import { ng } from '../../utils/process';
+
+
+export default async function () {
+  await writeMultipleFiles({
+    './src/app/foo.ts': `
+      export const foo = 'fooo';
+    `,
+    './src/app/bar.ts': `
+      import { foo } from 'app/foo';
+
+      console.log(foo);
+    `
+  }),
+
+  await prependToFile('src/app/app.module.ts', `import './bar';\n`);
+
+  await ng('build');
+  await ng('build', '--aot');
+}