Skip to content

Commit 57ed320

Browse files
author
Roman Shanin
committed
fix(parquet_writer): correctly update upper bound
1 parent 145afdf commit 57ed320

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

crates/iceberg/src/writer/file_writer/parquet_writer.rs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,7 @@ impl MinMaxColAggregator {
266266
self.upper_bounds
267267
.entry(field_id)
268268
.and_modify(|e| {
269-
if *e > datum {
269+
if *e < datum {
270270
*e = datum.clone()
271271
}
272272
})
@@ -853,7 +853,9 @@ mod tests {
853853

854854
// write data
855855
let mut pw = ParquetWriterBuilder::new(
856-
WriterProperties::builder().build(),
856+
WriterProperties::builder()
857+
.set_max_row_group_size(128)
858+
.build(),
857859
Arc::new(to_write.schema().as_ref().try_into().unwrap()),
858860
file_io.clone(),
859861
location_gen,

rustfmt.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,3 +24,4 @@ imports_granularity = "Module"
2424
overflow_delimited_expr = true
2525
trailing_comma = "Vertical"
2626
where_single_line = true
27+

0 commit comments

Comments
 (0)