Skip to content

Commit 5bbfc89

Browse files
committed
fix some its.. disable a test which need network access which is wrong
Signed-off-by: olivier lamy <[email protected]>
1 parent 58c0c6d commit 5bbfc89

File tree

4 files changed

+6
-2
lines changed

4 files changed

+6
-2
lines changed

src/it/projects/MJAVADOC-325/invoker.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,4 +19,4 @@ invoker.goals=clean javadoc:javadoc
1919
# Javadoc 12+ fails:
2020
# The code being documented uses modules but the packages defined in https://docs.oracle.com/javase/1.5.0/docs/api/ are in the unnamed module.
2121
# Unrelated to the issue
22-
invoker.java.version= 12-
22+
invoker.java.version= 11-

src/it/projects/MJAVADOC-325/pom.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,5 +52,4 @@
5252
</plugins>
5353
</pluginManagement>
5454
</build>
55-
5655
</project>

src/it/projects/MJAVADOC-575_source8-module-info/pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,7 @@
6666
</executions>
6767
<configuration>
6868
<source>8</source>
69+
<detectJavaApiLink>false</detectJavaApiLink>
6970
</configuration>
7071
</plugin>
7172
</plugins>

src/test/java/org/apache/maven/plugins/javadoc/JavadocReportTest.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@
5757
import org.codehaus.plexus.util.FileUtils;
5858
import org.codehaus.plexus.util.StringUtils;
5959
import org.junit.AssumptionViolatedException;
60+
import org.junit.Ignore;
6061
import org.sonatype.aether.impl.internal.SimpleLocalRepositoryManager;
6162

6263
/**
@@ -920,9 +921,12 @@ public void testJdk6()
920921
*
921922
* @throws Exception if any
922923
*/
924+
@Ignore("We don't really want to have unit test which need internet access")
923925
public void testProxy()
924926
throws Exception
925927
{
928+
// ignore test as annotation doesn't ignore anything..
929+
if(true) return;
926930
Settings settings = new Settings();
927931
Proxy proxy = new Proxy();
928932

0 commit comments

Comments
 (0)