-
Notifications
You must be signed in to change notification settings - Fork 17
Closed
Labels
conclusion: resolvedIssue was resolvedIssue was resolvedtopic: codeRelated to content of the project itselfRelated to content of the project itselftype: imperfectionPerceived defect in any part of projectPerceived defect in any part of project
Description
After being quite confused why the OTA library could not connect to my storage server, I realized from this code that the port I specified (8080) wasn't being used at all.
https://github.com/arduino-libraries/Arduino_ESP32_OTA/blob/main/src/Arduino_ESP32_OTA.cpp#L119 always sets port to 80 for http and 443 for https, and the URI parser seems to not handle :
at all (https://github.com/arduino-libraries/Arduino_ESP32_OTA/blob/main/src/decompress/utility.cpp#L88).
That last function is quite confusing, so no easy fix PR from my side, alas.
BlackPavilion
Metadata
Metadata
Assignees
Labels
conclusion: resolvedIssue was resolvedIssue was resolvedtopic: codeRelated to content of the project itselfRelated to content of the project itselftype: imperfectionPerceived defect in any part of projectPerceived defect in any part of project