Invalid sketch.json is silently ignored

[matthijskooijman]

Bug Report

Current behavior

matthijs@grubby:~/test$ tree
.
├── sketch.json
└── test.ino

0 directories, 2 files
matthijs@grubby:~/test$ cat sketch.json 
{ foo
matthijs@grubby:~/test$ arduino-cli compile -v

Error during build: no FQBN provided

When an invalid sketch.json is present, it is silently ignored.

Expected behavior

I would expect an error about sketch.json containing invalid JSON and no other messages.

Environment

• CLI version (output of arduino-cli version): arduino-cli alpha Version: 0.0.0-git Commit: Date:
• Not sure why arduino-cli version says nothing useful, but this is a locally compiled, slightly modified version based on bf364db from Feb 26.
• OS and platform: Linux / Ubuntu Focal / amd64

[per1234]

Not sure why arduino-cli version says nothing useful

This happens when you use go build instead of task build. Task build generates the data used by arduino-cli version:

arduino-cli/Taskfile.yml

Lines 217 to 223 in 436277f

	LDFLAGS: >
	-ldflags
	'
	-X github.com/arduino/arduino-cli/version.versionString={{.VERSION}}
	-X github.com/arduino/arduino-cli/version.commit={{ .COMMIT }}
	-X github.com/arduino/arduino-cli/version.date={{.TIMESTAMP}}
	'

[matthijskooijman]

This happens when you use go build instead of task build. Task build generates the data used by arduino-cli version:

Makes sense, thanks!

[umbynos]

We dropped support for sketch.json in favor of sketch.yaml in #1930