From b1edc0d8c412eea2c177238467980ec6e34b5815 Mon Sep 17 00:00:00 2001 From: Roberto Sora Date: Fri, 25 Oct 2019 11:02:42 +0200 Subject: [PATCH 01/10] [skip changelog] Force windows env to use cmd as shell instead of powershell --- .github/workflows/test.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 076f70f4f06..4ab258c9f86 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -32,6 +32,8 @@ jobs: go get github.com/golangci/govet go get golang.org/x/lint/golint go get github.com/golang/protobuf/protoc-gen-go + if: matrix.operating-system == 'windows-2019' + shell: cmd - name: Install Taskfile uses: Arduino/actions/setup-taskfile@master From 7dff1026a59c6a06b806fe3f93e0232f9f5bf1f8 Mon Sep 17 00:00:00 2001 From: Roberto Sora Date: Fri, 25 Oct 2019 11:13:11 +0200 Subject: [PATCH 02/10] temporarly enable only windows for test flow --- .github/workflows/test.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 4ab258c9f86..345356cfe8b 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -11,7 +11,8 @@ jobs: strategy: matrix: - operating-system: [ubuntu-18.04, windows-2019, macOS-10.14] + operating-system: [windows-2019] + # operating-system: [ubuntu-18.04, windows-2019, macOS-10.14] runs-on: ${{ matrix.operating-system }} From cf139035d710b00231c97ba922091632e8545456 Mon Sep 17 00:00:00 2001 From: Roberto Sora Date: Fri, 25 Oct 2019 11:34:44 +0200 Subject: [PATCH 03/10] moved up cmd default shell for windows at job level --- .github/workflows/test.yaml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 345356cfe8b..9a07c60a249 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -15,7 +15,8 @@ jobs: # operating-system: [ubuntu-18.04, windows-2019, macOS-10.14] runs-on: ${{ matrix.operating-system }} - + if: matrix.operating-system == 'windows-2019' + shell: cmd steps: - name: Disable EOL conversions run: git config --global core.autocrlf false @@ -33,8 +34,6 @@ jobs: go get github.com/golangci/govet go get golang.org/x/lint/golint go get github.com/golang/protobuf/protoc-gen-go - if: matrix.operating-system == 'windows-2019' - shell: cmd - name: Install Taskfile uses: Arduino/actions/setup-taskfile@master From 9db84575970609e58a58b81d98faae1479b635a1 Mon Sep 17 00:00:00 2001 From: Roberto Sora Date: Fri, 25 Oct 2019 11:41:33 +0200 Subject: [PATCH 04/10] revert and enable all --- .github/workflows/test.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 9a07c60a249..4ab258c9f86 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -11,12 +11,10 @@ jobs: strategy: matrix: - operating-system: [windows-2019] - # operating-system: [ubuntu-18.04, windows-2019, macOS-10.14] + operating-system: [ubuntu-18.04, windows-2019, macOS-10.14] runs-on: ${{ matrix.operating-system }} - if: matrix.operating-system == 'windows-2019' - shell: cmd + steps: - name: Disable EOL conversions run: git config --global core.autocrlf false @@ -34,6 +32,8 @@ jobs: go get github.com/golangci/govet go get golang.org/x/lint/golint go get github.com/golang/protobuf/protoc-gen-go + if: matrix.operating-system == 'windows-2019' + shell: cmd - name: Install Taskfile uses: Arduino/actions/setup-taskfile@master From b7971d78752194d20bf005ed147b792cec60a3dd Mon Sep 17 00:00:00 2001 From: Roberto Sora Date: Fri, 25 Oct 2019 11:43:45 +0200 Subject: [PATCH 05/10] disable macos --- .github/workflows/test.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 4ab258c9f86..c8886aa6732 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -11,7 +11,7 @@ jobs: strategy: matrix: - operating-system: [ubuntu-18.04, windows-2019, macOS-10.14] + operating-system: [ubuntu-18.04, windows-2019] #, macOS-10.14] runs-on: ${{ matrix.operating-system }} From fe0c1e8bf7aafa17044e495b984642349a517948 Mon Sep 17 00:00:00 2001 From: Roberto Sora Date: Fri, 25 Oct 2019 12:25:00 +0200 Subject: [PATCH 06/10] force use of cmd on windows only for go getting dependencies --- .github/workflows/test.yaml | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index c8886aa6732..86fe95f59b8 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -11,7 +11,7 @@ jobs: strategy: matrix: - operating-system: [ubuntu-18.04, windows-2019] #, macOS-10.14] + operating-system: [ubuntu-18.04, windows-2019, macOS-10.14] runs-on: ${{ matrix.operating-system }} @@ -28,12 +28,22 @@ jobs: go-version: '1.13' - name: Install Go deps + if: matrix.operating-system != 'windows-2019' + run: | + go get github.com/golangci/govet + go get golang.org/x/lint/golint + go get github.com/golang/protobuf/protoc-gen-go + + - name: Install Go deps on windows + # since 10/23/2019 pwsh is the default shell + # on Windows, but pwsh fails to install protoc-gen-go + # so we force cmd as default shell for this task + if: matrix.operating-system == 'windows-2019' + shell: cmd run: | go get github.com/golangci/govet go get golang.org/x/lint/golint go get github.com/golang/protobuf/protoc-gen-go - if: matrix.operating-system == 'windows-2019' - shell: cmd - name: Install Taskfile uses: Arduino/actions/setup-taskfile@master From 15c4b394616429bf8190e0d163e1a54ff7e15199 Mon Sep 17 00:00:00 2001 From: Roberto Sora Date: Fri, 25 Oct 2019 12:26:26 +0200 Subject: [PATCH 07/10] typo --- .github/workflows/test.yaml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 86fe95f59b8..3332b8be1f1 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -28,11 +28,11 @@ jobs: go-version: '1.13' - name: Install Go deps - if: matrix.operating-system != 'windows-2019' - run: | - go get github.com/golangci/govet - go get golang.org/x/lint/golint - go get github.com/golang/protobuf/protoc-gen-go + if: matrix.operating-system != 'windows-2019' + run: | + go get github.com/golangci/govet + go get golang.org/x/lint/golint + go get github.com/golang/protobuf/protoc-gen-go - name: Install Go deps on windows # since 10/23/2019 pwsh is the default shell From 7b1ece27baa2f4bc98b15af57dd5cf690d0e2a08 Mon Sep 17 00:00:00 2001 From: Roberto Sora Date: Fri, 25 Oct 2019 12:34:05 +0200 Subject: [PATCH 08/10] typo --- .github/workflows/test.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 3332b8be1f1..2c00d461c69 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -39,11 +39,11 @@ jobs: # on Windows, but pwsh fails to install protoc-gen-go # so we force cmd as default shell for this task if: matrix.operating-system == 'windows-2019' - shell: cmd run: | go get github.com/golangci/govet go get golang.org/x/lint/golint go get github.com/golang/protobuf/protoc-gen-go + shell: cmd - name: Install Taskfile uses: Arduino/actions/setup-taskfile@master From 86569aaa5b03fac2f6c48500e3c5ef8a59265c96 Mon Sep 17 00:00:00 2001 From: Roberto Sora Date: Mon, 28 Oct 2019 14:23:45 +0100 Subject: [PATCH 09/10] test using `bash` as default shell --- .github/workflows/test.yaml | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 2c00d461c69..7523d620fb6 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -28,22 +28,23 @@ jobs: go-version: '1.13' - name: Install Go deps - if: matrix.operating-system != 'windows-2019' +# if: matrix.operating-system != 'windows-2019' run: | go get github.com/golangci/govet go get golang.org/x/lint/golint go get github.com/golang/protobuf/protoc-gen-go - - - name: Install Go deps on windows - # since 10/23/2019 pwsh is the default shell - # on Windows, but pwsh fails to install protoc-gen-go - # so we force cmd as default shell for this task - if: matrix.operating-system == 'windows-2019' - run: | - go get github.com/golangci/govet - go get golang.org/x/lint/golint - go get github.com/golang/protobuf/protoc-gen-go - shell: cmd + shell: bash + +# - name: Install Go deps on windows +# # since 10/23/2019 pwsh is the default shell +# # on Windows, but pwsh fails to install protoc-gen-go +# # so we force cmd as default shell for this task +# if: matrix.operating-system == 'windows-2019' +# run: | +# go get github.com/golangci/govet +# go get golang.org/x/lint/golint +# go get github.com/golang/protobuf/protoc-gen-go +# shell: cmd - name: Install Taskfile uses: Arduino/actions/setup-taskfile@master From 34d923bdda8db89afb20872b494ec84bf067166a Mon Sep 17 00:00:00 2001 From: Roberto Sora Date: Mon, 28 Oct 2019 15:59:29 +0100 Subject: [PATCH 10/10] cleanup task and comment --- .github/workflows/test.yaml | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 7523d620fb6..12ac2ce94d4 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -28,24 +28,15 @@ jobs: go-version: '1.13' - name: Install Go deps -# if: matrix.operating-system != 'windows-2019' + # Since 10/23/2019 pwsh is the default shell + # on Windows, but pwsh fails to install protoc-gen-go so + # we force bash as default shell for all OSes in this task run: | go get github.com/golangci/govet go get golang.org/x/lint/golint go get github.com/golang/protobuf/protoc-gen-go shell: bash -# - name: Install Go deps on windows -# # since 10/23/2019 pwsh is the default shell -# # on Windows, but pwsh fails to install protoc-gen-go -# # so we force cmd as default shell for this task -# if: matrix.operating-system == 'windows-2019' -# run: | -# go get github.com/golangci/govet -# go get golang.org/x/lint/golint -# go get github.com/golang/protobuf/protoc-gen-go -# shell: cmd - - name: Install Taskfile uses: Arduino/actions/setup-taskfile@master