Validate value object required fields in the constructor (#1488)

* Refactor the code generating object properties

* Refactor the generation of array getters

Optional array fields still need to consider the property as nullable
even though the getter will return an empty array as AWS does not treat
absent lists the same than empty lists in input.

* Add validation of required parameters in value object constructors

* Remove checks for missing properties for value object request bodies

This is already validated in the constructor now.

Author: stof

src/ValueObject/RepositoryTrigger.php

@@ -52,11 +52,11 @@ final class RepositoryTrigger
      */
     public function __construct(array $input)
     {
-        $this->name = $input['name'] ?? null;
-        $this->destinationArn = $input['destinationArn'] ?? null;
+        $this->name = $input['name'] ?? $this->throwException(new InvalidArgument('Missing required field "name".'));
+        $this->destinationArn = $input['destinationArn'] ?? $this->throwException(new InvalidArgument('Missing required field "destinationArn".'));
         $this->customData = $input['customData'] ?? null;
         $this->branches = $input['branches'] ?? null;
-        $this->events = $input['events'] ?? null;
+        $this->events = $input['events'] ?? $this->throwException(new InvalidArgument('Missing required field "events".'));
     }
 
     /**
@@ -96,7 +96,7 @@ public function getDestinationArn(): string
      */
     public function getEvents(): array
     {
-        return $this->events ?? [];
+        return $this->events;
     }
 
     public function getName(): string
@@ -110,13 +110,9 @@ public function getName(): string
     public function requestBody(): array
     {
         $payload = [];
-        if (null === $v = $this->name) {
-            throw new InvalidArgument(sprintf('Missing parameter "name" for "%s". The value cannot be null.', __CLASS__));
-        }
+        $v = $this->name;
         $payload['name'] = $v;
-        if (null === $v = $this->destinationArn) {
-            throw new InvalidArgument(sprintf('Missing parameter "destinationArn" for "%s". The value cannot be null.', __CLASS__));
-        }
+        $v = $this->destinationArn;
         $payload['destinationArn'] = $v;
         if (null !== $v = $this->customData) {
             $payload['customData'] = $v;
@@ -129,9 +125,7 @@ public function requestBody(): array
                 $payload['branches'][$index] = $listValue;
             }
         }
-        if (null === $v = $this->events) {
-            throw new InvalidArgument(sprintf('Missing parameter "events" for "%s". The value cannot be null.', __CLASS__));
-        }
+        $v = $this->events;
 
         $index = -1;
         $payload['events'] = [];
@@ -145,4 +139,12 @@ public function requestBody(): array
 
         return $payload;
     }
+
+    /**
+     * @return never
+     */
+    private function throwException(\Throwable $exception)
+    {
+        throw $exception;
+    }
 }