SuggestionStore::GetCompletions to check exit code of invoked application fixed

baradgur · baradgur · commit 1c23816992ea · 2023-04-13T02:31:30.000+06:00
Fix dotnet#2147
diff --git a/src/System.CommandLine.Suggest/SuggestionStore.cs b/src/System.CommandLine.Suggest/SuggestionStore.cs
@@ -42,11 +42,9 @@ public string GetCompletions(string exeFileName, string suggestionTargetArgument
                 {
                     process.Start();
 
-                    Task<string> readToEndTask = process.StandardOutput.ReadToEndAsync();
-
-                    if (readToEndTask.Wait(timeout) && process.HasExited && process.ExitCode == 0)
+                    if (process.WaitForExit(timeout) && process.ExitCode == 0)
                     {
-                        result = readToEndTask.Result;
+                        result = process.StandardOutput.ReadToEnd();
                     }
                     else
                     {

Original file line number	Diff line number	Diff line change
`@@ -42,11 +42,9 @@ public string GetCompletions(string exeFileName, string suggestionTargetArgument`
`42`	`42`	`{`
`43`	`43`	`process.Start();`
`44`	`44`
`45`		`- Task<string> readToEndTask = process.StandardOutput.ReadToEndAsync();`
`46`		`-`
`47`		`- if (readToEndTask.Wait(timeout) && process.HasExited && process.ExitCode == 0)`
	`45`	`+ if (process.WaitForExit(timeout) && process.ExitCode == 0)`
`48`	`46`	`{`
`49`		`- result = readToEndTask.Result;`
	`47`	`+ result = process.StandardOutput.ReadToEnd();`
`50`	`48`	`}`
`51`	`49`	`else`
`52`	`50`	`{`