Skip to content

Commit 0a0df73

Browse files
Shellescape the identifier. Improve error messages.
1 parent af07f38 commit 0a0df73

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

autoload/hdevtools.vim

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -589,7 +589,7 @@ function! hdevtools#insert_type()
589589

590590
let l:pos_lines = split(l:output_for_pos, '\n')
591591
if len(l:pos_lines) == 0
592-
call hdevtools#print_error('hdevtools#insert_type: No Type Information. hdevtools answered: ' . l:output_for_pos)
592+
call hdevtools#print_error('hdevtools#insert_type: No Type Information.)
593593
return
594594
endif
595595
let l:pos_last_line = l:pos_lines[-1]
@@ -602,10 +602,11 @@ function! hdevtools#insert_type()
602602
let l:string_at_linenumber = getline(l:linenumber_of_identifier)
603603
let l:identifier = (split(l:string_at_linenumber))[0]
604604

605-
let l:cmd_to_get_type_of_identifier = hdevtools#build_command_bare('info', shellescape(l:file) . ' ' . l:identifier)
605+
let l:cmd_to_get_type_of_identifier = hdevtools#build_command_bare('info', shellescape(l:file) . ' ' . shellescape(l:identifier))
606606
let l:output_for_type = system(l:cmd_to_get_type_of_identifier)
607607

608608
if v:shell_error != 0
609+
call hdevtools#print_error("hdevtools#insert_type: Couldn't get type for " . l:identifier . ". hdevtools answered: " . l:last_line)
609610
for l:line in split(l:output_for_type, '\n')
610611
call hdevtools#print_error(l:line)
611612
endfor

0 commit comments

Comments
 (0)