refactor to use language object

Author: ABaldwinHunter

lib/cc/engine/analyzers/reporter.rb

@@ -60,27 +60,15 @@ def flay
 
         attr_reader :engine_config, :language_strategy, :io
 
-        def mass_threshold
-          @mass_threshold ||= language_strategy.mass_threshold
-        end
-
-        def base_points
-          @base_points ||= language_strategy.base_points
-        end
-
-        def points_per
-          @points_per ||= language_strategy.points_per
-        end
-
         def new_violation(issue)
           hashes = flay.hashes[issue.structural_hash]
-          Violation.new(base_points, points_per, mass_threshold, issue, hashes)
+          Violation.new(language_strategy, issue, hashes)
         end
 
         def flay_options
           {
             diff: false,
-            mass: mass_threshold,
+            mass: language_strategy.mass_threshold,
             summary: false,
             verbose: false,
             number: true,

lib/cc/engine/analyzers/violation.rb

@@ -10,10 +10,10 @@ class Violation
 
         DEFAULT_POINTS = 1_500_000
 
-        def initialize(base_points, points_per, threshold, issue, hashes)
-          @base_points = base_points
-          @points_per = points_per
-          @threshold = threshold
+        def initialize(language, issue, hashes)
+          @base_points = language.base_points
+          @points_per = language.points_per
+          @threshold = language.mass_threshold
           @issue = issue
           @hashes = hashes
         end

spec/cc/engine/analyzers/violation_spec.rb

@@ -4,15 +4,17 @@
   describe "#calculate_points" do
     context "when issue mass exceeds threshold" do
       it "calculates mass overage points" do
-        base_points = 100
-        points_per = 50
+        base_points =  100
+        points_per = 5
         threshold = 10
+
+        language = stub_language(base_points, points_per, threshold)
         issue = double(:issue, mass: 15)
         hashes = []
 
         expected_points = base_points + points_per * (issue.mass - threshold)
 
-        violation = CC::Engine::Analyzers::Violation.new(base_points, points_per, threshold, issue, hashes)
+        violation = CC::Engine::Analyzers::Violation.new(language, issue, hashes)
         points = violation.calculate_points
 
         expect(points).to eq(expected_points)
@@ -22,14 +24,16 @@
     context "when issue mass is less than threshold" do
       it "uses default" do
         base_points = 100
-        points_per = 50
+        points_per = 5
         threshold = 18
+
+        language = stub_language(base_points, points_per, threshold)
         issue = double(:issue, mass: 15)
         hashes = []
 
         expected_points = CC::Engine::Analyzers::Violation::DEFAULT_POINTS
 
-        violation = CC::Engine::Analyzers::Violation.new(base_points, points_per, threshold, issue, hashes)
+        violation = CC::Engine::Analyzers::Violation.new(language, issue, hashes)
         points = violation.calculate_points
 
         expect(points).to eq(CC::Engine::Analyzers::Violation::DEFAULT_POINTS)
@@ -39,18 +43,28 @@
     context "when issue mass equals threshold" do
       it "calculates remediation points" do
         base_points = 100
-        points_per = 50
+        points_per = 5
         threshold = 15
+
+        language = stub_language(base_points, points_per, threshold)
         issue = double(:issue, mass: 15)
         hashes = []
 
         expected_points = base_points + points_per * (issue.mass - threshold)
 
-        violation = CC::Engine::Analyzers::Violation.new(base_points, points_per, threshold, issue, hashes)
+        violation = CC::Engine::Analyzers::Violation.new(language, issue, hashes)
         points = violation.calculate_points
 
         expect(points).to eq(expected_points)
       end
     end
+
+    def stub_language(base_points, per_points, threshold)
+      double(:language,
+        base_points: base_points,
+        points_per: per_points,
+        mass_threshold: threshold
+      )
+    end
   end
 end