This repository was archived by the owner on Jul 19, 2025. It is now read-only.
Upgrade to latest versions of flay and sexp_processor
#383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This applies a small monkey patch to the `parse_sexp` method in the `sexp_processor` gem. This will allow us to continue passing filters to `Sexp::Matcher.parse` like this: ``` DEFAULT_FILTERS = [ "(UsingDirective ___)".freeze ].freeze ```
f-moya
reviewed
Dec 5, 2023
There was a problem hiding this comment.
@larkinscott have you confirmed ?
Note: I'm still confirming if the line number changes from this update make sense.
RubyBrewsday
approved these changes
Dec 5, 2023
larkinscott
added a commit
that referenced
this pull request
Dec 18, 2023
…)" This reverts commit fcdaf4a.
larkinscott
added a commit
that referenced
this pull request
Mar 19, 2024
…)" This reverts commit fcdaf4a.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also applies a small monkey patch to the
parse_sexpmethod in thesexp_processorgem. This will allow us to continue passing filters toSexp::Matcher.parselike this:Note: I'm still confirming if the line number changes from this update make sense.