Migrate to node module approach.

Author: GirlBossRush

.github/codeql-config.yml

@@ -1,4 +1 @@
 name: "code-server CodeQL config"
-
-paths-ignore:
-  - lib/vscode

.github/workflows/ci.yaml

@@ -124,26 +124,26 @@ jobs:
       - name: Build code-server
         run: yarn build
 
-      # Parse the hash of the latest commit inside lib/vscode
+      # Parse the hash of the latest commit inside node_modules/vscode
       # use this to avoid rebuilding it if nothing changed
       # How it works: the `git log` command fetches the hash of the last commit
-      # that changed a file inside `lib/vscode`. If a commit changes any file in there,
+      # that changed a file inside `node_modules/vscode`. If a commit changes any file in there,
       # the hash returned will change, and we rebuild vscode. If the hash did not change,
       # (for example, a change to `src/` or `docs/`), we reuse the same build as last time.
       # This saves a lot of time in CI, as compiling VSCode can take anywhere from 5-10 minutes.
-      - name: Get latest lib/vscode rev
+      - name: Get latest node_modules/vscode rev
         id: vscode-rev
-        run: echo "::set-output name=rev::$(git log -1 --format='%H' ./lib/vscode)"
+        run: echo "::set-output name=rev::$(cat node_modules/vscode/package.json | jq -r .version)"
 
       - name: Attempt to fetch vscode build from cache
         id: cache-vscode
         uses: actions/cache@v2
         with:
           path: |
-            lib/vscode/.build
-            lib/vscode/out-build
-            lib/vscode/out-vscode
-            lib/vscode/out-vscode-min
+            node_modules/vscode/.build
+            node_modules/vscode/out-build
+            node_modules/vscode/out-vscode
+            node_modules/vscode/out-vscode-min
           key: vscode-build-${{ steps.vscode-rev.outputs.rev }}
 
       - name: Build vscode

.gitignore

@@ -8,7 +8,7 @@ release-packages/
 release-gcp/
 release-images/
 node_modules
-/lib/vscode/node_modules.asar
+/node_modules.asar
 node-*
 /plugins
 /lib/coder-cloud-agent

.gitmodules

@@ -143,9 +143,9 @@
       "description": "Static images and the manifest live here in `src/browser/media` (see the explorer)."
     },
     {
-      "directory": "lib/vscode",
+      "directory": "node_modules/vscode",
       "line": 1,
       "description": "code-server makes use of VS Code's frontend web/remote support. Most of the modifications implement the remote server since that portion of the code is closed source and not released with VS Code.\n\nWe also have a few bug fixes and have added some features (like client-side extensions). See [https://github.com/cdr/code-server/blob/master/docs/CONTRIBUTING.md#modifications-to-vs-code](https://github.com/cdr/code-server/blob/master/docs/CONTRIBUTING.md#modifications-to-vs-code) for a list.\n\nWe make an effort to keep the modifications as few as possible."
     }
   ]
-}
+}

.tours/contributing.tour

@@ -12,12 +12,11 @@ KEEP_MODULES="${KEEP_MODULES-0}"
 
 main() {
   cd "$(dirname "${0}")/../.."
-  git submodule update --init
 
   source ./ci/lib.sh
 
-  VSCODE_SRC_PATH="lib/vscode"
-  VSCODE_OUT_PATH="$RELEASE_PATH/lib/vscode"
+  VSCODE_SRC_PATH="node_modules/vscode"
+  VSCODE_OUT_PATH="$RELEASE_PATH/node_modules/vscode"
 
   mkdir -p "$RELEASE_PATH"
 
@@ -26,7 +25,7 @@ main() {
 
   rsync ./docs/README.md "$RELEASE_PATH"
   rsync LICENSE.txt "$RELEASE_PATH"
-  rsync ./lib/vscode/ThirdPartyNotices.txt "$RELEASE_PATH"
+  rsync ./node_modules/vscode/ThirdPartyNotices.txt "$RELEASE_PATH"
 }
 
 bundle_code_server() {

ci/build/build-release.sh

@@ -33,7 +33,7 @@ main() {
   # leaves a few stray symlinks. Clean them up so nfpm does not fail.
   # Remove this line when its no longer needed.
 
-  rm -fr "$RELEASE_PATH/lib/vscode/extensions/node_modules/.bin"
+  rm -fr "$RELEASE_PATH/node_modules/vscode/extensions/node_modules/.bin"
 }
 
 main "$@"

ci/build/build-standalone-release.sh

@@ -1,15 +1,15 @@
 #!/usr/bin/env bash
 set -euo pipefail
 
-# Builds vscode into lib/vscode/out-vscode.
+# Builds vscode into node_modules/vscode/out-vscode.
 
 # MINIFY controls whether a minified version of vscode is built.
 MINIFY=${MINIFY-true}
 
 main() {
   cd "$(dirname "${0}")/../.."
 
-  cd lib/vscode
+  cd node_modules/vscode
 
   yarn gulp compile-build compile-extensions-build compile-extension-media
   yarn gulp optimize --gulpfile ./coder.js

ci/build/build-vscode.sh

@@ -7,7 +7,7 @@ main() {
 
   git clean -Xffd
 
-  pushd lib/vscode
+  pushd node_modules/vscode
   git clean -xffd
   popd
 }

ci/build/clean.sh

@@ -87,7 +87,7 @@ symlink_asar() {
 }
 
 vscode_yarn() {
-  cd lib/vscode
+  cd node_modules
 
   yarn --production --frozen-lockfile