From 0e154baa779f9de74e72c7a1674ffc69b4447896 Mon Sep 17 00:00:00 2001 From: Faur Ioan-Aurel Date: Tue, 20 Dec 2022 22:29:43 +0200 Subject: [PATCH 1/2] fixed: icon rendering on macOS - scaling and resizing on macOS was not taking into account HiDPI screens --- CHANGELOG.md | 3 +++ .../com/coder/gateway/sdk/TemplateIconDownloader.kt | 9 +++------ 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index ecbbb036..17949f2f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,9 @@ ### Changed - renamed the plugin from `Coder Gateway` to `Gateway` +### Fixed +- icon rendering on macOS + ## 2.1.3 - 2022-12-09 ### Added diff --git a/src/main/kotlin/com/coder/gateway/sdk/TemplateIconDownloader.kt b/src/main/kotlin/com/coder/gateway/sdk/TemplateIconDownloader.kt index 89e6a3b9..c4fe0db4 100644 --- a/src/main/kotlin/com/coder/gateway/sdk/TemplateIconDownloader.kt +++ b/src/main/kotlin/com/coder/gateway/sdk/TemplateIconDownloader.kt @@ -3,12 +3,12 @@ package com.coder.gateway.sdk import com.coder.gateway.icons.CoderIcons import com.intellij.openapi.components.Service import com.intellij.openapi.components.service -import com.intellij.ui.scale.ScaleContext +import com.intellij.util.IconUtil import com.intellij.util.ImageLoader import com.intellij.util.ui.ImageUtil +import org.imgscalr.Scalr import java.net.URL import javax.swing.Icon -import javax.swing.ImageIcon @Service(Service.Level.APP) class TemplateIconDownloader { @@ -25,10 +25,7 @@ class TemplateIconDownloader { if (url != null) { var img = ImageLoader.loadFromUrl(url) if (img != null) { - if (ImageUtil.getRealHeight(img) > 32 && ImageUtil.getRealWidth(img) > 32) { - img = ImageUtil.resize(img, 32, ScaleContext.create()) - } - return ImageIcon(img) + return IconUtil.toRetinaAwareIcon(Scalr.resize(ImageUtil.toBufferedImage(img), Scalr.Method.ULTRA_QUALITY, 32)) } } From c97865a42cf8478fa8145bebae6febda09506031 Mon Sep 17 00:00:00 2001 From: Faur Ioan-Aurel Date: Tue, 20 Dec 2022 22:31:21 +0200 Subject: [PATCH 2/2] chore: increase max compatible coder to 0.13.5 --- src/main/resources/version/CoderSupportedVersions.properties | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/resources/version/CoderSupportedVersions.properties b/src/main/resources/version/CoderSupportedVersions.properties index 12ba1ee3..280fb807 100644 --- a/src/main/resources/version/CoderSupportedVersions.properties +++ b/src/main/resources/version/CoderSupportedVersions.properties @@ -1,2 +1,2 @@ minCompatibleCoderVersion=0.12.9 -maxCompatibleCoderVersion=0.13.1 +maxCompatibleCoderVersion=0.13.5