From 611593ef91d0db965a8ed7faee41a9e6f73be3ec Mon Sep 17 00:00:00 2001 From: Faur Ioan-Aurel Date: Wed, 1 Mar 2023 01:41:18 +0200 Subject: [PATCH 1/2] fix: ui bindings - don't recreate a new data model because it screws up the bindings to the UI components - instead reset the URL and token --- .../com/coder/gateway/views/steps/CoderWorkspacesStepView.kt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/main/kotlin/com/coder/gateway/views/steps/CoderWorkspacesStepView.kt b/src/main/kotlin/com/coder/gateway/views/steps/CoderWorkspacesStepView.kt index 4326a246..cc7d8a6f 100644 --- a/src/main/kotlin/com/coder/gateway/views/steps/CoderWorkspacesStepView.kt +++ b/src/main/kotlin/com/coder/gateway/views/steps/CoderWorkspacesStepView.kt @@ -330,7 +330,8 @@ class CoderWorkspacesStepView(val enableNextButtonCallback: (Boolean) -> Unit) : else -> { logger.warn("An exception was encountered while opening ${localWizardModel.coderURL}. Reason: ${e.message}") - localWizardModel = CoderWorkspacesWizardModel() + localWizardModel.coderURL = "https://coder.example.com" + localWizardModel.token = "" tfUrl?.text = localWizardModel.coderURL } } From 3e3d38f566e7a67bb496401d78a5076783926a42 Mon Sep 17 00:00:00 2001 From: Faur Ioan-Aurel Date: Wed, 1 Mar 2023 02:02:39 +0200 Subject: [PATCH 2/2] fix: don't reset the URL - only reset the token, we want the user to quickly modify the existing URL --- .../com/coder/gateway/views/steps/CoderWorkspacesStepView.kt | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/main/kotlin/com/coder/gateway/views/steps/CoderWorkspacesStepView.kt b/src/main/kotlin/com/coder/gateway/views/steps/CoderWorkspacesStepView.kt index cc7d8a6f..a962a87f 100644 --- a/src/main/kotlin/com/coder/gateway/views/steps/CoderWorkspacesStepView.kt +++ b/src/main/kotlin/com/coder/gateway/views/steps/CoderWorkspacesStepView.kt @@ -330,9 +330,7 @@ class CoderWorkspacesStepView(val enableNextButtonCallback: (Boolean) -> Unit) : else -> { logger.warn("An exception was encountered while opening ${localWizardModel.coderURL}. Reason: ${e.message}") - localWizardModel.coderURL = "https://coder.example.com" localWizardModel.token = "" - tfUrl?.text = localWizardModel.coderURL } }