fix(commands): need to look in globals

of course! locals() inside the context of the function scope
only contains the function params and local variables!

Author: thekaveman

compiler_admin/commands/time/__init__.py

@@ -1,12 +1,15 @@
 from argparse import Namespace
 
-from compiler_admin.commands.time import convert  # noqa: F401
+from compiler_admin.commands.time.convert import convert  # noqa: F401
 
 
 def time(args: Namespace, *extra):
-    # try to call the subcommand function directly from local symbols
-    # if the subcommand function was imported above, it should exist in locals()
-    if args.subcommand in locals():
-        locals()[args.subcommand](args, *extra)
+    # try to call the subcommand function directly from global (module) symbols
+    # if the subcommand function was imported above, it should exist in globals()
+    global_env = globals()
+
+    if args.subcommand in global_env:
+        cmd_func = global_env[args.subcommand]
+        cmd_func(args, *extra)
     else:
         raise NotImplementedError(f"Unknown time subcommand: {args.subcommand}")

compiler_admin/commands/user/__init__.py

@@ -10,9 +10,12 @@
 
 
 def user(args: Namespace, *extra):
-    # try to call the subcommand function directly from local symbols
-    # if the subcommand function was imported above, it should exist in locals()
-    if args.subcommand in locals():
-        locals()[args.subcommand](args, *extra)
+    # try to call the subcommand function directly from global (module) symbols
+    # if the subcommand function was imported above, it should exist in globals()
+    global_env = globals()
+
+    if args.subcommand in global_env:
+        cmd_func = global_env[args.subcommand]
+        cmd_func(args, *extra)
     else:
         raise NotImplementedError(f"Unknown user subcommand: {args.subcommand}")

tests/commands/time/test__init__.py

@@ -7,17 +7,17 @@
 
 def test_time_subcommand_exists(mocker):
     args = Namespace(subcommand="subcmd")
-    subcmd = mocker.patch("compiler_admin.commands.time.locals", return_value={"subcmd": mocker.Mock()})
+    subcmd = mocker.patch("compiler_admin.commands.time.globals", return_value={"subcmd": mocker.Mock()})
 
     time(args, 1, 2, 3)
 
-    subcmd.assert_called()
+    subcmd.assert_called_once()
     subcmd.return_value["subcmd"].assert_called_once_with(args, 1, 2, 3)
 
 
 def test_time_subcommand_doesnt_exists(mocker):
     args = Namespace(subcommand="subcmd")
-    subcmd = mocker.patch("compiler_admin.commands.time.locals", return_value={})
+    subcmd = mocker.patch("compiler_admin.commands.time.globals", return_value={})
 
     with pytest.raises(NotImplementedError, match="Unknown time subcommand: subcmd"):
         time(args, 1, 2, 3)

tests/commands/user/test__init__.py

@@ -7,7 +7,7 @@
 
 def test_user_subcommand_exists(mocker):
     args = Namespace(subcommand="subcmd")
-    subcmd = mocker.patch("compiler_admin.commands.user.locals", return_value={"subcmd": mocker.Mock()})
+    subcmd = mocker.patch("compiler_admin.commands.user.globals", return_value={"subcmd": mocker.Mock()})
 
     user(args, 1, 2, 3)
 
@@ -17,7 +17,7 @@ def test_user_subcommand_exists(mocker):
 
 def test_time_subcommand_doesnt_exists(mocker):
     args = Namespace(subcommand="subcmd")
-    subcmd = mocker.patch("compiler_admin.commands.user.locals", return_value={})
+    subcmd = mocker.patch("compiler_admin.commands.user.globals", return_value={})
 
     with pytest.raises(NotImplementedError, match="Unknown user subcommand: subcmd"):
         user(args, 1, 2, 3)