From 72f2e62bbc01de1f25b76b0a5a9330ffe9132495 Mon Sep 17 00:00:00 2001
From: Rafal Galka <rafal.galka@modernweb.pl>
Date: Sat, 5 Oct 2019 14:17:36 +0200
Subject: [PATCH 1/2] fix(sidebar): nav link target doesn't work through
 appHtmlAttr

---
 .../app-sidebar-nav/app-sidebar-nav-link.component.html       | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/projects/coreui/angular/src/lib/sidebar/app-sidebar-nav/app-sidebar-nav-link.component.html b/projects/coreui/angular/src/lib/sidebar/app-sidebar-nav/app-sidebar-nav-link.component.html
index 549b1cb5..0b077ba9 100644
--- a/projects/coreui/angular/src/lib/sidebar/app-sidebar-nav/app-sidebar-nav-link.component.html
+++ b/projects/coreui/angular/src/lib/sidebar/app-sidebar-nav/app-sidebar-nav-link.component.html
@@ -2,7 +2,8 @@
   <a *ngSwitchCase="'external'"
     [ngClass]="getLinkClass()"
     href="{{item.url}}"
-    [appHtmlAttr]="item.attributes">
+    [appHtmlAttr]="item.attributes"
+    [target]="item.attributes.target ? item.attributes.target : '_self'">
     <i *ngIf="helper.hasIcon(item)" [ngClass]="item | appSidebarNavIcon"></i>
     <ng-container>{{item.name}}</ng-container>
     <span *ngIf="helper.hasBadge(item)" [ngClass]="item | appSidebarNavBadge">{{ item.badge.text }}</span>
@@ -10,6 +11,7 @@
   <a *ngSwitchDefault
      [ngClass]="getLinkClass()"
      [appHtmlAttr]="item.attributes"
+     [target]="item.attributes.target ? item.attributes.target : '_self'"
      [attr.disabled]="isDisabled()"
      routerLinkActive="active"
      [routerLink]="[item.url]"

From 7fb68216cce50277dab1728352f90583fc60f36b Mon Sep 17 00:00:00 2001
From: Rafal Galka <rafal.galka@modernweb.pl>
Date: Mon, 7 Oct 2019 22:37:03 +0200
Subject: [PATCH 2/2] fix(sidebar): nav link target not needed for external
 link

---
 .../app-sidebar-nav/app-sidebar-nav-link.component.html        | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/projects/coreui/angular/src/lib/sidebar/app-sidebar-nav/app-sidebar-nav-link.component.html b/projects/coreui/angular/src/lib/sidebar/app-sidebar-nav/app-sidebar-nav-link.component.html
index 0b077ba9..42268a2e 100644
--- a/projects/coreui/angular/src/lib/sidebar/app-sidebar-nav/app-sidebar-nav-link.component.html
+++ b/projects/coreui/angular/src/lib/sidebar/app-sidebar-nav/app-sidebar-nav-link.component.html
@@ -2,8 +2,7 @@
   <a *ngSwitchCase="'external'"
     [ngClass]="getLinkClass()"
     href="{{item.url}}"
-    [appHtmlAttr]="item.attributes"
-    [target]="item.attributes.target ? item.attributes.target : '_self'">
+    [appHtmlAttr]="item.attributes">
     <i *ngIf="helper.hasIcon(item)" [ngClass]="item | appSidebarNavIcon"></i>
     <ng-container>{{item.name}}</ng-container>
     <span *ngIf="helper.hasBadge(item)" [ngClass]="item | appSidebarNavBadge">{{ item.badge.text }}</span>