Skip to content

Commit 383e790

Browse files
committed
Update with review comments
1 parent de53cef commit 383e790

File tree

12 files changed

+20
-22
lines changed

12 files changed

+20
-22
lines changed

lib/resources/styles.css

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -461,20 +461,18 @@ h1 .category {
461461
}
462462

463463
.feature {
464-
padding: 2px 4px;
465-
font-size: 12px;
466-
border-radius: 4px;
467-
background-color: #999;
468-
text-transform: uppercase;
469-
color: white;
470-
opacity: .5;
471-
}
464+
display: inline-block;
465+
background: white;
466+
border: 1px solid #0175c2;
467+
border-radius: 20px;
468+
color: #0175c2;
472469

473-
.feature.feature-nnbd {
474-
background-color: #8d36ad;
470+
font-size: 12px;
471+
padding: 1px 6px;
472+
margin: 0 8px 0 0;
475473
}
476474

477-
feature .category {
475+
h1 .feature {
478476
vertical-align: middle;
479477
}
480478

lib/src/model/feature_set.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ mixin FeatureSet {
1818
// legacy interfaces.
1919
if (isNNBD) {
2020
yield LanguageFeature(
21-
'nnbd', packageGraph.rendererFactory.featureRenderer);
21+
'Null safety', packageGraph.rendererFactory.featureRenderer);
2222
}
2323
}
2424

lib/src/model/language_feature.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
import 'package:dartdoc/src/render/feature_renderer.dart';
66

77
const Map<String, String> _featureDescriptions = {
8-
'nnbd': 'This interface is non-nullable by default.',
8+
'Null safety': 'Supports the null safety language feature.',
99
};
1010

1111
/// An abstraction for a language feature; used to render tags to notify

lib/templates/html/class.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ <h5>{{parent.name}} {{parent.kind}}</h5>
88

99
<div id="dartdoc-main-content" class="col-xs-12 col-sm-9 col-md-8 main-content">
1010
{{#self}}
11-
<div>{{>source_link}}<h1><span class="kind-class">{{{nameWithGenerics}}}</span> {{kind}} {{>categorization}} {{>feature_set}}</h1></div>
11+
<div>{{>source_link}}<h1><span class="kind-class">{{{nameWithGenerics}}}</span> {{kind}} {{>feature_set}} {{>categorization}}</h1></div>
1212
{{/self}}
1313

1414
{{#clazz}}

lib/templates/html/enum.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ <h5>{{parent.name}} {{parent.kind}}</h5>
88

99
<div id="dartdoc-main-content" class="col-xs-12 col-sm-9 col-md-8 main-content">
1010
{{#self}}
11-
<div>{{>source_link}}<h1><span class="kind-enum">{{{name}}}</span> {{kind}} {{>categorization}} {{>feature_set}}</h1></div>
11+
<div>{{>source_link}}<h1><span class="kind-enum">{{{name}}}</span> {{kind}} {{>feature_set}} {{>categorization}}</h1></div>
1212
{{/self}}
1313

1414
{{#eNum}}

lib/templates/html/extension.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ <h5>{{parent.name}} {{parent.kind}}</h5>
88

99
<div id="dartdoc-main-content" class="col-xs-12 col-sm-9 col-md-8 main-content">
1010
{{#self}}
11-
<div>{{>source_link}}<h1><span class="kind-class">{{{nameWithGenerics}}}</span> {{kind}} {{>categorization}} {{>feature_set}}</h1></div>
11+
<div>{{>source_link}}<h1><span class="kind-class">{{{nameWithGenerics}}}</span> {{kind}} {{>feature_set}} {{>categorization}}</h1></div>
1212
{{/self}}
1313

1414
{{#extension}}

lib/templates/html/function.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ <h5>{{parent.name}} {{parent.kind}}</h5>
88

99
<div id="dartdoc-main-content" class="col-xs-12 col-sm-9 col-md-8 main-content">
1010
{{#self}}
11-
<div>{{>source_link}}<h1><span class="kind-function">{{{nameWithGenerics}}}</span> {{kind}} {{>categorization}} {{>feature_set}}</h1></div>
11+
<div>{{>source_link}}<h1><span class="kind-function">{{{nameWithGenerics}}}</span> {{kind}} {{>feature_set}} {{>categorization}}</h1></div>
1212
{{/self}}
1313

1414
{{#function}}

lib/templates/html/library.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ <h5><span class="package-name">{{parent.name}}</span> <span class="package-kind"
88

99
<div id="dartdoc-main-content" class="col-xs-12 col-sm-9 col-md-8 main-content">
1010
{{#self}}
11-
<div>{{>source_link}}<h1><span class="kind-library">{{{name}}}</span> {{kind}} {{>categorization}} {{>feature_set}}</h1></div>
11+
<div>{{>source_link}}<h1><span class="kind-library">{{{name}}}</span> {{kind}} {{>feature_set}} {{>categorization}}</h1></div>
1212
{{/self}}
1313

1414
{{#library}}

lib/templates/html/mixin.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ <h5>{{parent.name}} {{parent.kind}}</h5>
88

99
<div id="dartdoc-main-content" class="col-xs-12 col-sm-9 col-md-8 main-content">
1010
{{#self}}
11-
<div>{{>source_link}}<h1><span class="kind-mixin">{{{nameWithGenerics}}}</span> {{kind}} {{>categorization}} {{>feature_set}}</h1></div>
11+
<div>{{>source_link}}<h1><span class="kind-mixin">{{{nameWithGenerics}}}</span> {{kind}} {{>feature_set}} {{>categorization}}</h1></div>
1212
{{/self}}
1313

1414
{{#mixin}}

lib/templates/html/top_level_constant.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ <h5>{{parent.name}} {{parent.kind}}</h5>
88

99
<div id="dartdoc-main-content" class="col-xs-12 col-sm-9 col-md-8 main-content">
1010
{{#self}}
11-
<div>{{>source_link}}<h1><span class="kind-top-level-constant">{{{name}}}</span> {{kind}} {{>categorization}} {{>feature_set}}</h1></div>
11+
<div>{{>source_link}}<h1><span class="kind-top-level-constant">{{{name}}}</span> {{kind}} {{>feature_set}} {{>categorization}}</h1></div>
1212

1313
<section class="multi-line-signature">
1414
{{>name_summary}}

0 commit comments

Comments
 (0)