Moving tests that are supposed to create errors into a separate package.

Author: gspencergoog

test/model_test.dart

@@ -53,9 +53,11 @@ void main() {
 
   PackageGraph packageGraph;
   PackageGraph packageGraphSmall;
+  PackageGraph packageGraphErrors;
   PackageGraph ginormousPackageGraph;
   Library exLibrary;
   Library fakeLibrary;
+  Library errorLibrary;
   Library twoExportsLib;
   Library interceptorsLib;
   PackageGraph sdkAsPackageGraph;
@@ -65,8 +67,11 @@ void main() {
     await utils.init();
     packageGraph = utils.testPackageGraph;
     packageGraphSmall = utils.testPackageGraphSmall;
+    packageGraphErrors = utils.testPackageGraphErrors;
     ginormousPackageGraph = utils.testPackageGraphGinormous;
     exLibrary = packageGraph.libraries.firstWhere((lib) => lib.name == 'ex');
+    errorLibrary = packageGraphErrors.libraries
+        .firstWhere((lib) => lib.name == 'doc_errors');
     fakeLibrary =
         packageGraph.libraries.firstWhere((lib) => lib.name == 'fake');
     dartAsync =
@@ -97,10 +102,8 @@ void main() {
           invokeTool.documentation,
           contains(
               new RegExp(r'--source=lib[/\\]example\.dart_[0-9]+_[0-9]+, ')));
-      expect(
-          invokeTool.documentation,
-          contains(new RegExp(
-              r'--package-path=<PACKAGE_PATH>, ')));
+      expect(invokeTool.documentation,
+          contains(new RegExp(r'--package-path=<PACKAGE_PATH>, ')));
       expect(
           invokeTool.documentation, contains('--package-name=test_package, '));
       expect(invokeTool.documentation, contains('--library-name=ex, '));
@@ -115,10 +118,8 @@ void main() {
           contains(new RegExp('SOURCE_COLUMN: [0-9]+, ')));
       expect(invokeTool.documentation,
           contains(new RegExp(r'SOURCE_PATH: lib[/\\]example\.dart, ')));
-      expect(
-          invokeTool.documentation,
-          contains(new RegExp(
-              r'PACKAGE_PATH: <PACKAGE_PATH>, ')));
+      expect(invokeTool.documentation,
+          contains(new RegExp(r'PACKAGE_PATH: <PACKAGE_PATH>, ')));
       expect(
           invokeTool.documentation, contains('PACKAGE_NAME: test_package, '));
       expect(invokeTool.documentation, contains('LIBRARY_NAME: ex, '));
@@ -731,99 +732,50 @@ void main() {
     });
   });
 
-  group('Animation', () {
-    Class dog;
-    Method withAnimation;
-    Method withNamedAnimation;
-    Method withQuoteNamedAnimation;
+  group('Animation Errors', () {
+    Class documentationErrors;
     Method withInvalidNamedAnimation;
-    Method withDeprecatedAnimation;
     Method withAnimationNonUnique;
     Method withAnimationNonUniqueDeprecated;
     Method withAnimationWrongParams;
     Method withAnimationBadWidth;
     Method withAnimationBadHeight;
-    Method withAnimationInOneLineDoc;
-    Method withAnimationInline;
-    Method withAnimationOutOfOrder;
     Method withAnimationUnknownArg;
 
     setUp(() {
-      dog = exLibrary.classes.firstWhere((c) => c.name == 'Dog');
-      withAnimation =
-          dog.allInstanceMethods.firstWhere((m) => m.name == 'withAnimation');
-      withNamedAnimation = dog.allInstanceMethods
-          .firstWhere((m) => m.name == 'withNamedAnimation');
-      withQuoteNamedAnimation = dog.allInstanceMethods
-          .firstWhere((m) => m.name == 'withQuotedNamedAnimation');
-      withInvalidNamedAnimation = dog.allInstanceMethods
+      documentationErrors = errorLibrary.classes
+          .firstWhere((c) => c.name == 'DocumentationErrors');
+      withInvalidNamedAnimation = documentationErrors.allInstanceMethods
           .firstWhere((m) => m.name == 'withInvalidNamedAnimation');
-      withDeprecatedAnimation = dog.allInstanceMethods
-          .firstWhere((m) => m.name == 'withDeprecatedAnimation');
-      withAnimationNonUnique = dog.allInstanceMethods
+      withAnimationNonUnique = documentationErrors.allInstanceMethods
           .firstWhere((m) => m.name == 'withAnimationNonUnique');
-      withAnimationNonUniqueDeprecated = dog.allInstanceMethods
+      withAnimationNonUniqueDeprecated = documentationErrors.allInstanceMethods
           .firstWhere((m) => m.name == 'withAnimationNonUniqueDeprecated');
-      withAnimationWrongParams = dog.allInstanceMethods
+      withAnimationWrongParams = documentationErrors.allInstanceMethods
           .firstWhere((m) => m.name == 'withAnimationWrongParams');
-      withAnimationBadWidth = dog.allInstanceMethods
+      withAnimationBadWidth = documentationErrors.allInstanceMethods
           .firstWhere((m) => m.name == 'withAnimationBadWidth');
-      withAnimationBadHeight = dog.allInstanceMethods
+      withAnimationBadHeight = documentationErrors.allInstanceMethods
           .firstWhere((m) => m.name == 'withAnimationBadHeight');
-      withAnimationInOneLineDoc = dog.allInstanceMethods
-          .firstWhere((m) => m.name == 'withAnimationInOneLineDoc');
-      withAnimationInline = dog.allInstanceMethods
-          .firstWhere((m) => m.name == 'withAnimationInline');
-      withAnimationOutOfOrder = dog.allInstanceMethods
-          .firstWhere((m) => m.name == 'withAnimationOutOfOrder');
-      withAnimationUnknownArg = dog.allInstanceMethods
+      withAnimationUnknownArg = documentationErrors.allInstanceMethods
           .firstWhere((m) => m.name == 'withAnimationUnknownArg');
-      packageGraph.allLocalModelElements.forEach((m) => m.documentation);
+      packageGraphErrors.allLocalModelElements.forEach((m) => m.documentation);
     });
 
-    test("renders an unnamed animation within the method documentation", () {
-      expect(withAnimation.documentation, contains('<video id="animation_1"'));
-    });
-    test("renders a named animation within the method documentation", () {
-      expect(withNamedAnimation.documentation,
-          contains('<video id="namedAnimation"'));
-    });
-    test("renders a quoted, named animation within the method documentation",
-        () {
-      expect(withQuoteNamedAnimation.documentation,
-          contains('<video id="quotedNamedAnimation"'));
-      expect(withQuoteNamedAnimation.documentation,
-          contains('<video id="quotedNamedAnimation2"'));
-    });
     test("warns with invalidly-named animation within the method documentation",
         () {
       expect(
-          packageGraph.packageWarningCounter.hasWarning(
+          packageGraphErrors.packageWarningCounter.hasWarning(
               withInvalidNamedAnimation,
               PackageWarning.invalidParameter,
               'An animation has an invalid identifier, "2isNot-A-ValidName". '
               'The identifier can only contain letters, numbers and '
               'underscores, and must not begin with a number.'),
           isTrue);
     });
-    test("renders a deprecated-form animation within the method documentation",
-        () {
-      expect(withDeprecatedAnimation.documentation,
-          contains('<video id="deprecatedAnimation"'));
-      expect(
-          packageGraph.packageWarningCounter.hasWarning(
-              withDeprecatedAnimation,
-              PackageWarning.deprecated,
-              'Deprecated form of @animation directive, '
-              '"{@animation deprecatedAnimation 100 100 http://host/path/to/video.mp4}"\n'
-              'Animation directives are now of the form "{@animation '
-              'WIDTH HEIGHT URL [id=ID]}" (id is an optional '
-              'parameter)'),
-          isTrue);
-    });
     test("warns on a non-unique animation name within a method", () {
       expect(
-          packageGraph.packageWarningCounter.hasWarning(
+          packageGraphErrors.packageWarningCounter.hasWarning(
               withAnimationNonUnique,
               PackageWarning.invalidParameter,
               'An animation has a non-unique identifier, "barHerderAnimation". '
@@ -833,7 +785,7 @@ void main() {
     test("warns on a non-unique animation name within a deprecated-form method",
         () {
       expect(
-          packageGraph.packageWarningCounter.hasWarning(
+          packageGraphErrors.packageWarningCounter.hasWarning(
               withAnimationNonUniqueDeprecated,
               PackageWarning.invalidParameter,
               'An animation has a non-unique identifier, "fooHerderAnimation". '
@@ -842,7 +794,7 @@ void main() {
     });
     test("warns on animation with missing parameters", () {
       expect(
-          packageGraph.packageWarningCounter.hasWarning(
+          packageGraphErrors.packageWarningCounter.hasWarning(
               withAnimationWrongParams,
               PackageWarning.invalidParameter,
               'Invalid @animation directive, "{@animation http://host/path/to/video.mp4}"\n'
@@ -852,7 +804,7 @@ void main() {
     });
     test("warns on animation with non-integer width", () {
       expect(
-          packageGraph.packageWarningCounter.hasWarning(
+          packageGraphErrors.packageWarningCounter.hasWarning(
               withAnimationBadWidth,
               PackageWarning.invalidParameter,
               'An animation has an invalid width (badWidthAnimation), "100px". '
@@ -861,13 +813,82 @@ void main() {
     });
     test("warns on animation with non-integer height", () {
       expect(
-          packageGraph.packageWarningCounter.hasWarning(
+          packageGraphErrors.packageWarningCounter.hasWarning(
               withAnimationBadHeight,
               PackageWarning.invalidParameter,
               'An animation has an invalid height (badHeightAnimation), '
               '"100px". The height must be an integer.'),
           isTrue);
     });
+    test("Unknown arguments generate an error.", () {
+      expect(
+          packageGraphErrors.packageWarningCounter.hasWarning(
+              withAnimationUnknownArg,
+              PackageWarning.invalidParameter,
+              'The {@animation ...} directive was called with invalid '
+              'parameters. FormatException: Could not find an option named "name".'),
+          isTrue);
+    });
+  });
+
+  group('Animation', () {
+    Class dog;
+    Method withAnimation;
+    Method withNamedAnimation;
+    Method withQuoteNamedAnimation;
+    Method withDeprecatedAnimation;
+    Method withAnimationInOneLineDoc;
+    Method withAnimationInline;
+    Method withAnimationOutOfOrder;
+
+    setUp(() {
+      dog = exLibrary.classes.firstWhere((c) => c.name == 'Dog');
+      withAnimation =
+          dog.allInstanceMethods.firstWhere((m) => m.name == 'withAnimation');
+      withNamedAnimation = dog.allInstanceMethods
+          .firstWhere((m) => m.name == 'withNamedAnimation');
+      withQuoteNamedAnimation = dog.allInstanceMethods
+          .firstWhere((m) => m.name == 'withQuotedNamedAnimation');
+      withDeprecatedAnimation = dog.allInstanceMethods
+          .firstWhere((m) => m.name == 'withDeprecatedAnimation');
+      withAnimationInOneLineDoc = dog.allInstanceMethods
+          .firstWhere((m) => m.name == 'withAnimationInOneLineDoc');
+      withAnimationInline = dog.allInstanceMethods
+          .firstWhere((m) => m.name == 'withAnimationInline');
+      withAnimationOutOfOrder = dog.allInstanceMethods
+          .firstWhere((m) => m.name == 'withAnimationOutOfOrder');
+      packageGraph.allLocalModelElements.forEach((m) => m.documentation);
+    });
+
+    test("renders an unnamed animation within the method documentation", () {
+      expect(withAnimation.documentation, contains('<video id="animation_1"'));
+    });
+    test("renders a named animation within the method documentation", () {
+      expect(withNamedAnimation.documentation,
+          contains('<video id="namedAnimation"'));
+    });
+    test("renders a quoted, named animation within the method documentation",
+        () {
+      expect(withQuoteNamedAnimation.documentation,
+          contains('<video id="quotedNamedAnimation"'));
+      expect(withQuoteNamedAnimation.documentation,
+          contains('<video id="quotedNamedAnimation2"'));
+    });
+    test("renders a deprecated-form animation within the method documentation",
+        () {
+      expect(withDeprecatedAnimation.documentation,
+          contains('<video id="deprecatedAnimation"'));
+      expect(
+          packageGraph.packageWarningCounter.hasWarning(
+              withDeprecatedAnimation,
+              PackageWarning.deprecated,
+              'Deprecated form of @animation directive, '
+              '"{@animation deprecatedAnimation 100 100 http://host/path/to/video.mp4}"\n'
+              'Animation directives are now of the form "{@animation '
+              'WIDTH HEIGHT URL [id=ID]}" (id is an optional '
+              'parameter)'),
+          isTrue);
+    });
     test("Doesn't place animations in one line doc", () {
       expect(withAnimationInOneLineDoc.oneLineDoc, isNot(contains('<video')));
       expect(withAnimationInOneLineDoc.documentation, contains('<video'));
@@ -881,15 +902,6 @@ void main() {
       expect(withAnimationOutOfOrder.documentation,
           contains('<video id="outOfOrder"'));
     });
-    test("Unknown arguments generate an error.", () {
-      expect(
-          packageGraph.packageWarningCounter.hasWarning(
-              withAnimationUnknownArg,
-              PackageWarning.invalidParameter,
-              'The {@animation ...} directive was called with invalid '
-              'parameters. FormatException: Could not find an option named "name".'),
-          isTrue);
-    });
   });
 
   group('MultiplyInheritedExecutableElement handling', () {
@@ -1570,7 +1582,7 @@ void main() {
     });
 
     test('get methods', () {
-      expect(Dog.publicInstanceMethods, hasLength(26));
+      expect(Dog.publicInstanceMethods, hasLength(19));
     });
 
     test('get operators', () {
@@ -1636,23 +1648,16 @@ void main() {
             'testMethod',
             'toString',
             'withAnimation',
-            'withAnimationBadHeight',
-            'withAnimationBadWidth',
             'withAnimationInline',
+            'withAnimationOutOfOrder',
             'withAnimationInOneLineDoc',
-            'withAnimationNonUnique',
-            'withAnimationNonUniqueDeprecated',
-            'withAnimationWrongParams',
             'withDeprecatedAnimation',
-            'withInvalidNamedAnimation',
             'withMacro',
             'withMacro2',
             'withNamedAnimation',
             'withPrivateMacro',
             'withQuotedNamedAnimation',
-            'withUndefinedMacro',
-            'withAnimationOutOfOrder',
-            'withAnimationUnknownArg',
+            'withUndefinedMacro'
           ]));
     });
 

test/src/utils.dart

@@ -17,6 +17,7 @@ PackageMeta sdkPackageMeta;
 PackageGraph testPackageGraph;
 PackageGraph testPackageGraphGinormous;
 PackageGraph testPackageGraphSmall;
+PackageGraph testPackageGraphErrors;
 PackageGraph testPackageGraphSdk;
 
 final Directory testPackageBadDir = new Directory('testing/test_package_bad');
@@ -78,6 +79,10 @@ void init({List<String> additionalArguments}) async {
   testPackageGraphSmall = await bootBasicPackage(
       'testing/test_package_small', [],
       additionalArguments: additionalArguments);
+
+  testPackageGraphErrors = await bootBasicPackage(
+      'testing/test_package_doc_errors', ['css', 'code_in_comments', 'excluded'],
+      additionalArguments: additionalArguments);
   testPackageGraphSdk = await bootSdkPackage();
 }