Skip to content

Commit 939e285

Browse files
authored
Update documentation for Webdev release process (#1771)
1 parent 0428ffb commit 939e285

File tree

4 files changed

+54
-42
lines changed

4 files changed

+54
-42
lines changed

dwds/CONTRIBUTING.md

Lines changed: 4 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -56,32 +56,8 @@ Launching lib/main.dart on Chrome in debug mode...
5656

5757
### With WebDev
5858

59-
1. In the `/webdev` directory, run `pub global activate --source path webdev`
60-
(this only needs to be run once)
61-
1. Uncomment the dwds dependency override in `/webdev/webdev/pubspec.yaml`, then
62-
run `dart run build_runner build` from `/webdev/webdev` directory
63-
- *Note: You will have to comment and build, and then uncomment and build,
64-
each time you need to pick up new changes*
65-
1. From `/webdev/example`, run `webdev serve --debug --verbose` (Note: all
66-
options can be found by running `webdev help serve`)
67-
1. Type opt/alt-d in the browser. This is required to start the VM.
68-
1. \[OPTIONAL\] If you need to connect a locally running DevTools (instructions
69-
for running
70-
[here](https://github.com/flutter/devtools/blob/master/CONTRIBUTING.md)),
71-
then close the DevTools that automatically opened in the previous step. Copy
72-
and paste the debug URI (should be logged in your terminal) into the DevTools
73-
connection box.
74-
75-
### Note:
76-
77-
If you get this error:
78-
79-
`The /webdev/webdev/pubspec.yaml file has changed since the /webdev/webdev/pubspec.lock file was generated, please run "dart pub get" again.`
80-
81-
You need to do the following:
82-
83-
- `rm webdev/webdev/pubspec.lock`
84-
- Then, from `/webdev/webdev` run `dart pub get`
59+
Follow instructions in the `webdev/example` [README](/example/README.md) to run
60+
the example app and connect to DWDS.
8561

8662
## Changes required when submitting a PR
8763

@@ -131,22 +107,8 @@ You need to do the following:
131107
> *Note: DWDS is a dependency of Webdev, which is why DWDS must be published
132108
> before Webdev can be published.*
133109
134-
- Make sure you are on the Dart stable SDK version (check with `dart --version`)
135-
- Update the DWDS version in `/webdev/pubspec.yaml` to match the newly released
136-
DWDS version, and update the Webdev version to the new version number. Also,
137-
comment out the dependency_override so that Webdev is now depending on the
138-
version of DWDS on pub (which should have just been published) instead of the
139-
local version.
140-
- Update `/webdev/CHANGELOG.md` to match the new webdev version
141-
- From `/webdev`, run `dart pub upgrade`
142-
- From `/webdev` run `dart run build_runner build`, this will build and update
143-
the version in `webdev/lib/src/version.dart`
144-
- Submit a PR with those changes (example PR:
145-
https://github.com/dart-lang/webdev/pull/1498)
146-
- Once the PR is submitted, pull from master and run `dart pub publish`
147-
- Finally, go to https://github.com/dart-lang/webdev/releases and create a new
148-
release, eg https://github.com/dart-lang/webdev/releases/tag/webdev-v2.7.8.
149-
You might need to delete some of the content of the autogenerated notes.
110+
Follow instructions in the `webdev/webdev`
111+
[CONTRIBUTING](/webdev/CONTRIBUTING.md) to release Webdev.
150112

151113
## Whenever the Dart SDK is updated
152114

example/README.md

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
# Running the example app
2+
3+
1. In the root directory of `webdev`, run
4+
`pub global activate --source path webdev`
5+
1. Uncomment the dwds dependency override in `/webdev/webdev/pubspec.yaml`, then
6+
run `dart run build_runner build` from `/webdev/webdev` directory
7+
- *Note: You will have to comment and build, and then uncomment and build,
8+
each time you need to pick up new changes*
9+
1. From `/webdev/example`, run `webdev serve --debug --verbose` (Note: all
10+
options can be found by running `webdev help serve`)
11+
1. Type opt/alt-d in the browser. This is required to start the VM.
12+
1. \[OPTIONAL\] If you need to connect a locally running DevTools (instructions
13+
for running
14+
[here](https://github.com/flutter/devtools/blob/master/CONTRIBUTING.md)),
15+
then close the DevTools that automatically opened in the previous step. Copy
16+
and paste the debug URI (should be logged in your terminal) into the DevTools
17+
connection box.
18+
19+
### Note:
20+
21+
If you get this error:
22+
23+
`The /webdev/webdev/pubspec.yaml file has changed since the /webdev/webdev/pubspec.lock file was generated, please run "dart pub get" again.`
24+
25+
You need to do the following:
26+
27+
- `rm webdev/webdev/pubspec.lock`
28+
- Then, from `/webdev/webdev` run `dart pub get`

webdev/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
## 2.7.12-dev.0
2+
23
- Migrate Webdev to null-safety.
34

45
## 2.7.11

webdev/CONTRIBUTING.md

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
## Instructions on releasing Webdev
2+
3+
- Make sure you are on the Dart stable SDK version (check with `dart --version`)
4+
- Update the DWDS version in `/webdev/pubspec.yaml` to match the newly released
5+
DWDS version, and update the Webdev version to the new version number. Also,
6+
comment out the dependency_override so that Webdev is now depending on the
7+
version of DWDS on pub (which should have just been published) instead of the
8+
local version.
9+
- Update `/webdev/CHANGELOG.md` to match the new webdev version
10+
- From `/webdev`, run `dart pub upgrade`
11+
- From `/webdev` run `dart run build_runner build`, this will build and update
12+
the version in `webdev/lib/src/version.dart`
13+
- Before submitting your PR, test that everything is working by following
14+
instructions in the `webdev/example` [README](/example/README.md) to run the
15+
example app and connect to Dart DevTools.
16+
- Submit a PR with those changes (example PR:
17+
https://github.com/dart-lang/webdev/pull/1498)
18+
- Once the PR is submitted, pull from master and run `dart pub publish`
19+
- Finally, go to https://github.com/dart-lang/webdev/releases and create a new
20+
release, eg https://github.com/dart-lang/webdev/releases/tag/webdev-v2.7.8.
21+
You might need to delete some of the content of the autogenerated notes.

0 commit comments

Comments
 (0)