diff --git a/3.10/alpine/20-management_agent.disable_metrics_collector.conf b/3.10/alpine/20-management_agent.disable_metrics_collector.conf new file mode 100644 index 00000000..6eb7a86c --- /dev/null +++ b/3.10/alpine/20-management_agent.disable_metrics_collector.conf @@ -0,0 +1,2 @@ +# Enable Prometheus-style metrics by default (https://github.com/docker-library/rabbitmq/issues/419) +management_agent.disable_metrics_collector = true diff --git a/3.10/alpine/Dockerfile b/3.10/alpine/Dockerfile index e7bb49de..007d9863 100644 --- a/3.10/alpine/Dockerfile +++ b/3.10/alpine/Dockerfile @@ -263,10 +263,7 @@ RUN set -eux; \ rm "$RABBITMQ_DATA_DIR/.erlang.cookie" # Enable Prometheus-style metrics by default (https://github.com/docker-library/rabbitmq/issues/419) -RUN set -eux; \ - su-exec rabbitmq rabbitmq-plugins enable --offline rabbitmq_prometheus; \ - echo 'management_agent.disable_metrics_collector = true' > /etc/rabbitmq/conf.d/management_agent.disable_metrics_collector.conf; \ - chown rabbitmq:rabbitmq /etc/rabbitmq/conf.d/management_agent.disable_metrics_collector.conf +RUN su-exec rabbitmq rabbitmq-plugins enable --offline rabbitmq_prometheus # Added for backwards compatibility - users can simply COPY custom plugins to /plugins RUN ln -sf /opt/rabbitmq/plugins /plugins @@ -281,7 +278,7 @@ VOLUME $RABBITMQ_DATA_DIR # https://docs.docker.com/samples/library/ubuntu/#locales ENV LANG=C.UTF-8 LANGUAGE=C.UTF-8 LC_ALL=C.UTF-8 -COPY --chown=rabbitmq:rabbitmq 10-defaults.conf /etc/rabbitmq/conf.d/ +COPY --chown=rabbitmq:rabbitmq 10-defaults.conf 20-management_agent.disable_metrics_collector.conf /etc/rabbitmq/conf.d/ COPY docker-entrypoint.sh /usr/local/bin/ ENTRYPOINT ["docker-entrypoint.sh"] diff --git a/3.10/alpine/management/Dockerfile b/3.10/alpine/management/Dockerfile index cf04de6d..7e7c4256 100644 --- a/3.10/alpine/management/Dockerfile +++ b/3.10/alpine/management/Dockerfile @@ -9,7 +9,7 @@ FROM rabbitmq:3.10-alpine RUN set eux; \ rabbitmq-plugins enable --offline rabbitmq_management; \ # make sure the metrics collector is re-enabled (disabled in the base image for Prometheus-style metrics by default) - rm -f /etc/rabbitmq/conf.d/management_agent.disable_metrics_collector.conf; \ + rm -f /etc/rabbitmq/conf.d/20-management_agent.disable_metrics_collector.conf; \ # grab "rabbitmqadmin" from inside the "rabbitmq_management-X.Y.Z" plugin folder # see https://github.com/docker-library/rabbitmq/issues/207 cp /plugins/rabbitmq_management-*/priv/www/cli/rabbitmqadmin /usr/local/bin/rabbitmqadmin; \ diff --git a/3.10/ubuntu/20-management_agent.disable_metrics_collector.conf b/3.10/ubuntu/20-management_agent.disable_metrics_collector.conf new file mode 100644 index 00000000..6eb7a86c --- /dev/null +++ b/3.10/ubuntu/20-management_agent.disable_metrics_collector.conf @@ -0,0 +1,2 @@ +# Enable Prometheus-style metrics by default (https://github.com/docker-library/rabbitmq/issues/419) +management_agent.disable_metrics_collector = true diff --git a/3.10/ubuntu/Dockerfile b/3.10/ubuntu/Dockerfile index 7c903d74..28448476 100644 --- a/3.10/ubuntu/Dockerfile +++ b/3.10/ubuntu/Dockerfile @@ -259,10 +259,7 @@ RUN set -eux; \ rm "$RABBITMQ_DATA_DIR/.erlang.cookie" # Enable Prometheus-style metrics by default (https://github.com/docker-library/rabbitmq/issues/419) -RUN set -eux; \ - gosu rabbitmq rabbitmq-plugins enable --offline rabbitmq_prometheus; \ - echo 'management_agent.disable_metrics_collector = true' > /etc/rabbitmq/conf.d/management_agent.disable_metrics_collector.conf; \ - chown rabbitmq:rabbitmq /etc/rabbitmq/conf.d/management_agent.disable_metrics_collector.conf +RUN gosu rabbitmq rabbitmq-plugins enable --offline rabbitmq_prometheus # Added for backwards compatibility - users can simply COPY custom plugins to /plugins RUN ln -sf /opt/rabbitmq/plugins /plugins @@ -277,7 +274,7 @@ VOLUME $RABBITMQ_DATA_DIR # https://docs.docker.com/samples/library/ubuntu/#locales ENV LANG=C.UTF-8 LANGUAGE=C.UTF-8 LC_ALL=C.UTF-8 -COPY --chown=rabbitmq:rabbitmq 10-defaults.conf /etc/rabbitmq/conf.d/ +COPY --chown=rabbitmq:rabbitmq 10-defaults.conf 20-management_agent.disable_metrics_collector.conf /etc/rabbitmq/conf.d/ COPY docker-entrypoint.sh /usr/local/bin/ ENTRYPOINT ["docker-entrypoint.sh"] diff --git a/3.10/ubuntu/management/Dockerfile b/3.10/ubuntu/management/Dockerfile index d16b0c99..477024fd 100644 --- a/3.10/ubuntu/management/Dockerfile +++ b/3.10/ubuntu/management/Dockerfile @@ -9,7 +9,7 @@ FROM rabbitmq:3.10 RUN set eux; \ rabbitmq-plugins enable --offline rabbitmq_management; \ # make sure the metrics collector is re-enabled (disabled in the base image for Prometheus-style metrics by default) - rm -f /etc/rabbitmq/conf.d/management_agent.disable_metrics_collector.conf; \ + rm -f /etc/rabbitmq/conf.d/20-management_agent.disable_metrics_collector.conf; \ # grab "rabbitmqadmin" from inside the "rabbitmq_management-X.Y.Z" plugin folder # see https://github.com/docker-library/rabbitmq/issues/207 cp /plugins/rabbitmq_management-*/priv/www/cli/rabbitmqadmin /usr/local/bin/rabbitmqadmin; \ diff --git a/3.11/alpine/20-management_agent.disable_metrics_collector.conf b/3.11/alpine/20-management_agent.disable_metrics_collector.conf new file mode 100644 index 00000000..6eb7a86c --- /dev/null +++ b/3.11/alpine/20-management_agent.disable_metrics_collector.conf @@ -0,0 +1,2 @@ +# Enable Prometheus-style metrics by default (https://github.com/docker-library/rabbitmq/issues/419) +management_agent.disable_metrics_collector = true diff --git a/3.11/alpine/Dockerfile b/3.11/alpine/Dockerfile index ab784925..1f6ada77 100644 --- a/3.11/alpine/Dockerfile +++ b/3.11/alpine/Dockerfile @@ -263,10 +263,7 @@ RUN set -eux; \ rm "$RABBITMQ_DATA_DIR/.erlang.cookie" # Enable Prometheus-style metrics by default (https://github.com/docker-library/rabbitmq/issues/419) -RUN set -eux; \ - su-exec rabbitmq rabbitmq-plugins enable --offline rabbitmq_prometheus; \ - echo 'management_agent.disable_metrics_collector = true' > /etc/rabbitmq/conf.d/management_agent.disable_metrics_collector.conf; \ - chown rabbitmq:rabbitmq /etc/rabbitmq/conf.d/management_agent.disable_metrics_collector.conf +RUN su-exec rabbitmq rabbitmq-plugins enable --offline rabbitmq_prometheus # Added for backwards compatibility - users can simply COPY custom plugins to /plugins RUN ln -sf /opt/rabbitmq/plugins /plugins @@ -281,7 +278,7 @@ VOLUME $RABBITMQ_DATA_DIR # https://docs.docker.com/samples/library/ubuntu/#locales ENV LANG=C.UTF-8 LANGUAGE=C.UTF-8 LC_ALL=C.UTF-8 -COPY --chown=rabbitmq:rabbitmq 10-defaults.conf /etc/rabbitmq/conf.d/ +COPY --chown=rabbitmq:rabbitmq 10-defaults.conf 20-management_agent.disable_metrics_collector.conf /etc/rabbitmq/conf.d/ COPY docker-entrypoint.sh /usr/local/bin/ ENTRYPOINT ["docker-entrypoint.sh"] diff --git a/3.11/alpine/management/Dockerfile b/3.11/alpine/management/Dockerfile index ba32dd25..613f7a96 100644 --- a/3.11/alpine/management/Dockerfile +++ b/3.11/alpine/management/Dockerfile @@ -9,7 +9,7 @@ FROM rabbitmq:3.11-alpine RUN set eux; \ rabbitmq-plugins enable --offline rabbitmq_management; \ # make sure the metrics collector is re-enabled (disabled in the base image for Prometheus-style metrics by default) - rm -f /etc/rabbitmq/conf.d/management_agent.disable_metrics_collector.conf; \ + rm -f /etc/rabbitmq/conf.d/20-management_agent.disable_metrics_collector.conf; \ # grab "rabbitmqadmin" from inside the "rabbitmq_management-X.Y.Z" plugin folder # see https://github.com/docker-library/rabbitmq/issues/207 cp /plugins/rabbitmq_management-*/priv/www/cli/rabbitmqadmin /usr/local/bin/rabbitmqadmin; \ diff --git a/3.11/ubuntu/20-management_agent.disable_metrics_collector.conf b/3.11/ubuntu/20-management_agent.disable_metrics_collector.conf new file mode 100644 index 00000000..6eb7a86c --- /dev/null +++ b/3.11/ubuntu/20-management_agent.disable_metrics_collector.conf @@ -0,0 +1,2 @@ +# Enable Prometheus-style metrics by default (https://github.com/docker-library/rabbitmq/issues/419) +management_agent.disable_metrics_collector = true diff --git a/3.11/ubuntu/Dockerfile b/3.11/ubuntu/Dockerfile index dcaf4b40..a973a4b7 100644 --- a/3.11/ubuntu/Dockerfile +++ b/3.11/ubuntu/Dockerfile @@ -259,10 +259,7 @@ RUN set -eux; \ rm "$RABBITMQ_DATA_DIR/.erlang.cookie" # Enable Prometheus-style metrics by default (https://github.com/docker-library/rabbitmq/issues/419) -RUN set -eux; \ - gosu rabbitmq rabbitmq-plugins enable --offline rabbitmq_prometheus; \ - echo 'management_agent.disable_metrics_collector = true' > /etc/rabbitmq/conf.d/management_agent.disable_metrics_collector.conf; \ - chown rabbitmq:rabbitmq /etc/rabbitmq/conf.d/management_agent.disable_metrics_collector.conf +RUN gosu rabbitmq rabbitmq-plugins enable --offline rabbitmq_prometheus # Added for backwards compatibility - users can simply COPY custom plugins to /plugins RUN ln -sf /opt/rabbitmq/plugins /plugins @@ -277,7 +274,7 @@ VOLUME $RABBITMQ_DATA_DIR # https://docs.docker.com/samples/library/ubuntu/#locales ENV LANG=C.UTF-8 LANGUAGE=C.UTF-8 LC_ALL=C.UTF-8 -COPY --chown=rabbitmq:rabbitmq 10-defaults.conf /etc/rabbitmq/conf.d/ +COPY --chown=rabbitmq:rabbitmq 10-defaults.conf 20-management_agent.disable_metrics_collector.conf /etc/rabbitmq/conf.d/ COPY docker-entrypoint.sh /usr/local/bin/ ENTRYPOINT ["docker-entrypoint.sh"] diff --git a/3.11/ubuntu/management/Dockerfile b/3.11/ubuntu/management/Dockerfile index b8944551..4c828e2d 100644 --- a/3.11/ubuntu/management/Dockerfile +++ b/3.11/ubuntu/management/Dockerfile @@ -9,7 +9,7 @@ FROM rabbitmq:3.11 RUN set eux; \ rabbitmq-plugins enable --offline rabbitmq_management; \ # make sure the metrics collector is re-enabled (disabled in the base image for Prometheus-style metrics by default) - rm -f /etc/rabbitmq/conf.d/management_agent.disable_metrics_collector.conf; \ + rm -f /etc/rabbitmq/conf.d/20-management_agent.disable_metrics_collector.conf; \ # grab "rabbitmqadmin" from inside the "rabbitmq_management-X.Y.Z" plugin folder # see https://github.com/docker-library/rabbitmq/issues/207 cp /plugins/rabbitmq_management-*/priv/www/cli/rabbitmqadmin /usr/local/bin/rabbitmqadmin; \ diff --git a/3.12-rc/alpine/20-management_agent.disable_metrics_collector.conf b/3.12-rc/alpine/20-management_agent.disable_metrics_collector.conf new file mode 100644 index 00000000..6eb7a86c --- /dev/null +++ b/3.12-rc/alpine/20-management_agent.disable_metrics_collector.conf @@ -0,0 +1,2 @@ +# Enable Prometheus-style metrics by default (https://github.com/docker-library/rabbitmq/issues/419) +management_agent.disable_metrics_collector = true diff --git a/3.12-rc/alpine/Dockerfile b/3.12-rc/alpine/Dockerfile index 4ddd0a4b..1f4b5472 100644 --- a/3.12-rc/alpine/Dockerfile +++ b/3.12-rc/alpine/Dockerfile @@ -263,10 +263,7 @@ RUN set -eux; \ rm "$RABBITMQ_DATA_DIR/.erlang.cookie" # Enable Prometheus-style metrics by default (https://github.com/docker-library/rabbitmq/issues/419) -RUN set -eux; \ - su-exec rabbitmq rabbitmq-plugins enable --offline rabbitmq_prometheus; \ - echo 'management_agent.disable_metrics_collector = true' > /etc/rabbitmq/conf.d/management_agent.disable_metrics_collector.conf; \ - chown rabbitmq:rabbitmq /etc/rabbitmq/conf.d/management_agent.disable_metrics_collector.conf +RUN su-exec rabbitmq rabbitmq-plugins enable --offline rabbitmq_prometheus # Added for backwards compatibility - users can simply COPY custom plugins to /plugins RUN ln -sf /opt/rabbitmq/plugins /plugins @@ -281,7 +278,7 @@ VOLUME $RABBITMQ_DATA_DIR # https://docs.docker.com/samples/library/ubuntu/#locales ENV LANG=C.UTF-8 LANGUAGE=C.UTF-8 LC_ALL=C.UTF-8 -COPY --chown=rabbitmq:rabbitmq 10-defaults.conf /etc/rabbitmq/conf.d/ +COPY --chown=rabbitmq:rabbitmq 10-defaults.conf 20-management_agent.disable_metrics_collector.conf /etc/rabbitmq/conf.d/ COPY docker-entrypoint.sh /usr/local/bin/ ENTRYPOINT ["docker-entrypoint.sh"] diff --git a/3.12-rc/alpine/management/Dockerfile b/3.12-rc/alpine/management/Dockerfile index 4faa96a7..5a1eadc2 100644 --- a/3.12-rc/alpine/management/Dockerfile +++ b/3.12-rc/alpine/management/Dockerfile @@ -9,7 +9,7 @@ FROM rabbitmq:3.12-rc-alpine RUN set eux; \ rabbitmq-plugins enable --offline rabbitmq_management; \ # make sure the metrics collector is re-enabled (disabled in the base image for Prometheus-style metrics by default) - rm -f /etc/rabbitmq/conf.d/management_agent.disable_metrics_collector.conf; \ + rm -f /etc/rabbitmq/conf.d/20-management_agent.disable_metrics_collector.conf; \ # grab "rabbitmqadmin" from inside the "rabbitmq_management-X.Y.Z" plugin folder # see https://github.com/docker-library/rabbitmq/issues/207 cp /plugins/rabbitmq_management-*/priv/www/cli/rabbitmqadmin /usr/local/bin/rabbitmqadmin; \ diff --git a/3.12-rc/ubuntu/20-management_agent.disable_metrics_collector.conf b/3.12-rc/ubuntu/20-management_agent.disable_metrics_collector.conf new file mode 100644 index 00000000..6eb7a86c --- /dev/null +++ b/3.12-rc/ubuntu/20-management_agent.disable_metrics_collector.conf @@ -0,0 +1,2 @@ +# Enable Prometheus-style metrics by default (https://github.com/docker-library/rabbitmq/issues/419) +management_agent.disable_metrics_collector = true diff --git a/3.12-rc/ubuntu/Dockerfile b/3.12-rc/ubuntu/Dockerfile index 68effec6..7339a0f8 100644 --- a/3.12-rc/ubuntu/Dockerfile +++ b/3.12-rc/ubuntu/Dockerfile @@ -259,10 +259,7 @@ RUN set -eux; \ rm "$RABBITMQ_DATA_DIR/.erlang.cookie" # Enable Prometheus-style metrics by default (https://github.com/docker-library/rabbitmq/issues/419) -RUN set -eux; \ - gosu rabbitmq rabbitmq-plugins enable --offline rabbitmq_prometheus; \ - echo 'management_agent.disable_metrics_collector = true' > /etc/rabbitmq/conf.d/management_agent.disable_metrics_collector.conf; \ - chown rabbitmq:rabbitmq /etc/rabbitmq/conf.d/management_agent.disable_metrics_collector.conf +RUN gosu rabbitmq rabbitmq-plugins enable --offline rabbitmq_prometheus # Added for backwards compatibility - users can simply COPY custom plugins to /plugins RUN ln -sf /opt/rabbitmq/plugins /plugins @@ -277,7 +274,7 @@ VOLUME $RABBITMQ_DATA_DIR # https://docs.docker.com/samples/library/ubuntu/#locales ENV LANG=C.UTF-8 LANGUAGE=C.UTF-8 LC_ALL=C.UTF-8 -COPY --chown=rabbitmq:rabbitmq 10-defaults.conf /etc/rabbitmq/conf.d/ +COPY --chown=rabbitmq:rabbitmq 10-defaults.conf 20-management_agent.disable_metrics_collector.conf /etc/rabbitmq/conf.d/ COPY docker-entrypoint.sh /usr/local/bin/ ENTRYPOINT ["docker-entrypoint.sh"] diff --git a/3.12-rc/ubuntu/management/Dockerfile b/3.12-rc/ubuntu/management/Dockerfile index 67cc3853..45e75e4a 100644 --- a/3.12-rc/ubuntu/management/Dockerfile +++ b/3.12-rc/ubuntu/management/Dockerfile @@ -9,7 +9,7 @@ FROM rabbitmq:3.12-rc RUN set eux; \ rabbitmq-plugins enable --offline rabbitmq_management; \ # make sure the metrics collector is re-enabled (disabled in the base image for Prometheus-style metrics by default) - rm -f /etc/rabbitmq/conf.d/management_agent.disable_metrics_collector.conf; \ + rm -f /etc/rabbitmq/conf.d/20-management_agent.disable_metrics_collector.conf; \ # grab "rabbitmqadmin" from inside the "rabbitmq_management-X.Y.Z" plugin folder # see https://github.com/docker-library/rabbitmq/issues/207 cp /plugins/rabbitmq_management-*/priv/www/cli/rabbitmqadmin /usr/local/bin/rabbitmqadmin; \ diff --git a/3.9/alpine/20-management_agent.disable_metrics_collector.conf b/3.9/alpine/20-management_agent.disable_metrics_collector.conf new file mode 100644 index 00000000..6eb7a86c --- /dev/null +++ b/3.9/alpine/20-management_agent.disable_metrics_collector.conf @@ -0,0 +1,2 @@ +# Enable Prometheus-style metrics by default (https://github.com/docker-library/rabbitmq/issues/419) +management_agent.disable_metrics_collector = true diff --git a/3.9/alpine/Dockerfile b/3.9/alpine/Dockerfile index b14ed18c..5d403424 100644 --- a/3.9/alpine/Dockerfile +++ b/3.9/alpine/Dockerfile @@ -263,10 +263,7 @@ RUN set -eux; \ rm "$RABBITMQ_DATA_DIR/.erlang.cookie" # Enable Prometheus-style metrics by default (https://github.com/docker-library/rabbitmq/issues/419) -RUN set -eux; \ - su-exec rabbitmq rabbitmq-plugins enable --offline rabbitmq_prometheus; \ - echo 'management_agent.disable_metrics_collector = true' > /etc/rabbitmq/conf.d/management_agent.disable_metrics_collector.conf; \ - chown rabbitmq:rabbitmq /etc/rabbitmq/conf.d/management_agent.disable_metrics_collector.conf +RUN su-exec rabbitmq rabbitmq-plugins enable --offline rabbitmq_prometheus # Added for backwards compatibility - users can simply COPY custom plugins to /plugins RUN ln -sf /opt/rabbitmq/plugins /plugins @@ -281,7 +278,7 @@ VOLUME $RABBITMQ_DATA_DIR # https://docs.docker.com/samples/library/ubuntu/#locales ENV LANG=C.UTF-8 LANGUAGE=C.UTF-8 LC_ALL=C.UTF-8 -COPY --chown=rabbitmq:rabbitmq 10-defaults.conf /etc/rabbitmq/conf.d/ +COPY --chown=rabbitmq:rabbitmq 10-defaults.conf 20-management_agent.disable_metrics_collector.conf /etc/rabbitmq/conf.d/ COPY docker-entrypoint.sh /usr/local/bin/ ENTRYPOINT ["docker-entrypoint.sh"] diff --git a/3.9/alpine/management/Dockerfile b/3.9/alpine/management/Dockerfile index 332d7fcf..a2c0da39 100644 --- a/3.9/alpine/management/Dockerfile +++ b/3.9/alpine/management/Dockerfile @@ -9,7 +9,7 @@ FROM rabbitmq:3.9-alpine RUN set eux; \ rabbitmq-plugins enable --offline rabbitmq_management; \ # make sure the metrics collector is re-enabled (disabled in the base image for Prometheus-style metrics by default) - rm -f /etc/rabbitmq/conf.d/management_agent.disable_metrics_collector.conf; \ + rm -f /etc/rabbitmq/conf.d/20-management_agent.disable_metrics_collector.conf; \ # grab "rabbitmqadmin" from inside the "rabbitmq_management-X.Y.Z" plugin folder # see https://github.com/docker-library/rabbitmq/issues/207 cp /plugins/rabbitmq_management-*/priv/www/cli/rabbitmqadmin /usr/local/bin/rabbitmqadmin; \ diff --git a/3.9/ubuntu/20-management_agent.disable_metrics_collector.conf b/3.9/ubuntu/20-management_agent.disable_metrics_collector.conf new file mode 100644 index 00000000..6eb7a86c --- /dev/null +++ b/3.9/ubuntu/20-management_agent.disable_metrics_collector.conf @@ -0,0 +1,2 @@ +# Enable Prometheus-style metrics by default (https://github.com/docker-library/rabbitmq/issues/419) +management_agent.disable_metrics_collector = true diff --git a/3.9/ubuntu/Dockerfile b/3.9/ubuntu/Dockerfile index 773ccf98..883c172f 100644 --- a/3.9/ubuntu/Dockerfile +++ b/3.9/ubuntu/Dockerfile @@ -259,10 +259,7 @@ RUN set -eux; \ rm "$RABBITMQ_DATA_DIR/.erlang.cookie" # Enable Prometheus-style metrics by default (https://github.com/docker-library/rabbitmq/issues/419) -RUN set -eux; \ - gosu rabbitmq rabbitmq-plugins enable --offline rabbitmq_prometheus; \ - echo 'management_agent.disable_metrics_collector = true' > /etc/rabbitmq/conf.d/management_agent.disable_metrics_collector.conf; \ - chown rabbitmq:rabbitmq /etc/rabbitmq/conf.d/management_agent.disable_metrics_collector.conf +RUN gosu rabbitmq rabbitmq-plugins enable --offline rabbitmq_prometheus # Added for backwards compatibility - users can simply COPY custom plugins to /plugins RUN ln -sf /opt/rabbitmq/plugins /plugins @@ -277,7 +274,7 @@ VOLUME $RABBITMQ_DATA_DIR # https://docs.docker.com/samples/library/ubuntu/#locales ENV LANG=C.UTF-8 LANGUAGE=C.UTF-8 LC_ALL=C.UTF-8 -COPY --chown=rabbitmq:rabbitmq 10-defaults.conf /etc/rabbitmq/conf.d/ +COPY --chown=rabbitmq:rabbitmq 10-defaults.conf 20-management_agent.disable_metrics_collector.conf /etc/rabbitmq/conf.d/ COPY docker-entrypoint.sh /usr/local/bin/ ENTRYPOINT ["docker-entrypoint.sh"] diff --git a/3.9/ubuntu/management/Dockerfile b/3.9/ubuntu/management/Dockerfile index 98462697..a9006005 100644 --- a/3.9/ubuntu/management/Dockerfile +++ b/3.9/ubuntu/management/Dockerfile @@ -9,7 +9,7 @@ FROM rabbitmq:3.9 RUN set eux; \ rabbitmq-plugins enable --offline rabbitmq_management; \ # make sure the metrics collector is re-enabled (disabled in the base image for Prometheus-style metrics by default) - rm -f /etc/rabbitmq/conf.d/management_agent.disable_metrics_collector.conf; \ + rm -f /etc/rabbitmq/conf.d/20-management_agent.disable_metrics_collector.conf; \ # grab "rabbitmqadmin" from inside the "rabbitmq_management-X.Y.Z" plugin folder # see https://github.com/docker-library/rabbitmq/issues/207 cp /plugins/rabbitmq_management-*/priv/www/cli/rabbitmqadmin /usr/local/bin/rabbitmqadmin; \ diff --git a/Dockerfile-alpine.template b/Dockerfile-alpine.template index 95218a03..c1d46eeb 100644 --- a/Dockerfile-alpine.template +++ b/Dockerfile-alpine.template @@ -293,10 +293,7 @@ RUN set -eux; \ rm "$RABBITMQ_DATA_DIR/.erlang.cookie" # Enable Prometheus-style metrics by default (https://github.com/docker-library/rabbitmq/issues/419) -RUN set -eux; \ - su-exec rabbitmq rabbitmq-plugins enable --offline rabbitmq_prometheus; \ - echo 'management_agent.disable_metrics_collector = true' > /etc/rabbitmq/conf.d/management_agent.disable_metrics_collector.conf; \ - chown rabbitmq:rabbitmq /etc/rabbitmq/conf.d/management_agent.disable_metrics_collector.conf +RUN su-exec rabbitmq rabbitmq-plugins enable --offline rabbitmq_prometheus # Added for backwards compatibility - users can simply COPY custom plugins to /plugins RUN ln -sf /opt/rabbitmq/plugins /plugins @@ -311,7 +308,7 @@ VOLUME $RABBITMQ_DATA_DIR # https://docs.docker.com/samples/library/ubuntu/#locales ENV LANG=C.UTF-8 LANGUAGE=C.UTF-8 LC_ALL=C.UTF-8 -COPY --chown=rabbitmq:rabbitmq 10-defaults.conf /etc/rabbitmq/conf.d/ +COPY --chown=rabbitmq:rabbitmq 10-defaults.conf 20-management_agent.disable_metrics_collector.conf /etc/rabbitmq/conf.d/ COPY docker-entrypoint.sh /usr/local/bin/ ENTRYPOINT ["docker-entrypoint.sh"] diff --git a/Dockerfile-management.template b/Dockerfile-management.template index 65c72a0d..8467fc1b 100644 --- a/Dockerfile-management.template +++ b/Dockerfile-management.template @@ -6,7 +6,7 @@ FROM {{ RUN set eux; \ rabbitmq-plugins enable --offline rabbitmq_management; \ # make sure the metrics collector is re-enabled (disabled in the base image for Prometheus-style metrics by default) - rm -f /etc/rabbitmq/conf.d/management_agent.disable_metrics_collector.conf; \ + rm -f /etc/rabbitmq/conf.d/20-management_agent.disable_metrics_collector.conf; \ # grab "rabbitmqadmin" from inside the "rabbitmq_management-X.Y.Z" plugin folder # see https://github.com/docker-library/rabbitmq/issues/207 cp /plugins/rabbitmq_management-*/priv/www/cli/rabbitmqadmin /usr/local/bin/rabbitmqadmin; \ diff --git a/Dockerfile-ubuntu.template b/Dockerfile-ubuntu.template index 05f2881a..a133b552 100644 --- a/Dockerfile-ubuntu.template +++ b/Dockerfile-ubuntu.template @@ -289,10 +289,7 @@ RUN set -eux; \ rm "$RABBITMQ_DATA_DIR/.erlang.cookie" # Enable Prometheus-style metrics by default (https://github.com/docker-library/rabbitmq/issues/419) -RUN set -eux; \ - gosu rabbitmq rabbitmq-plugins enable --offline rabbitmq_prometheus; \ - echo 'management_agent.disable_metrics_collector = true' > /etc/rabbitmq/conf.d/management_agent.disable_metrics_collector.conf; \ - chown rabbitmq:rabbitmq /etc/rabbitmq/conf.d/management_agent.disable_metrics_collector.conf +RUN gosu rabbitmq rabbitmq-plugins enable --offline rabbitmq_prometheus # Added for backwards compatibility - users can simply COPY custom plugins to /plugins RUN ln -sf /opt/rabbitmq/plugins /plugins @@ -307,7 +304,7 @@ VOLUME $RABBITMQ_DATA_DIR # https://docs.docker.com/samples/library/ubuntu/#locales ENV LANG=C.UTF-8 LANGUAGE=C.UTF-8 LC_ALL=C.UTF-8 -COPY --chown=rabbitmq:rabbitmq 10-defaults.conf /etc/rabbitmq/conf.d/ +COPY --chown=rabbitmq:rabbitmq 10-defaults.conf 20-management_agent.disable_metrics_collector.conf /etc/rabbitmq/conf.d/ COPY docker-entrypoint.sh /usr/local/bin/ ENTRYPOINT ["docker-entrypoint.sh"] diff --git a/apply-templates.sh b/apply-templates.sh index a61267b8..bd72b0c8 100755 --- a/apply-templates.sh +++ b/apply-templates.sh @@ -48,7 +48,7 @@ for version; do gawk -f "$jqt" "Dockerfile-$variant.template" } > "$version/$variant/Dockerfile" - cp -a 10-defaults.conf docker-entrypoint.sh "$version/$variant/" + cp -f docker-entrypoint.sh conf.d/*.conf "$version/$variant/" if [ "$variant" = 'alpine' ]; then sed -i -e 's/gosu/su-exec/g' "$version/$variant/docker-entrypoint.sh" diff --git a/10-defaults.conf b/conf.d/10-defaults.conf similarity index 100% rename from 10-defaults.conf rename to conf.d/10-defaults.conf diff --git a/conf.d/20-management_agent.disable_metrics_collector.conf b/conf.d/20-management_agent.disable_metrics_collector.conf new file mode 100644 index 00000000..6eb7a86c --- /dev/null +++ b/conf.d/20-management_agent.disable_metrics_collector.conf @@ -0,0 +1,2 @@ +# Enable Prometheus-style metrics by default (https://github.com/docker-library/rabbitmq/issues/419) +management_agent.disable_metrics_collector = true