Merge | LocalDbConfig #3171
Merged
Merge | LocalDbConfig #3171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benrr101
added
the
Common Project 🚮
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3171 +/- ##
==========================================
- Coverage 72.96% 72.79% -0.18%
==========================================
Files 283 284 +1
Lines 58997 59110 +113
==========================================
- Hits 43048 43029 -19
- Misses 15949 16081 +132
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cheenamalhotra
approved these changes
Feb 25, 2025
mdaigle
approved these changes
Feb 26, 2025
This was referenced Jul 25, 2025
Open
This was referenced Aug 1, 2025
Closed
This was referenced Aug 15, 2025
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Finally back on track for merging the netfx and netcore projects. In this exciting installment, we're merging the LocalDbConfig file. This file contains a few class definitions that are used to provide an object model for accessing the program's configuration file. They only apply to netfx, and can be easily moved into the common project, tagged as netfx, and wrapped in
#if NETFRAMEWORK. The file was also split into separate files for class and placed in a folder that better represents the namespace (Microsoft.Data.SqlClient.LocalDb).Testing: No functional changes, just moving things around.