-
Notifications
You must be signed in to change notification settings - Fork 311
Merge | Port PR 499 to .NET Framework #3255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3255 +/- ##
==========================================
- Coverage 72.69% 66.30% -6.39%
==========================================
Files 303 292 -11
Lines 59718 59324 -394
==========================================
- Hits 43414 39337 -4077
- Misses 16304 19987 +3683
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like basically a 1:1 port and tests pass ✔️
This ports #499 from netcore to netfx.
Relates to #1261.
Relates to #2965.
Once this PR is finished, the next PR which touches SqlDataReader will be able to merge it.
I'd appreciate a CI run of this please.