Skip to content

Merge | Port PR 499 to .NET Framework #3255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025

Conversation

edwardneal
Copy link
Contributor

@edwardneal edwardneal commented Apr 2, 2025

This ports #499 from netcore to netfx.

Relates to #1261.
Relates to #2965.

Once this PR is finished, the next PR which touches SqlDataReader will be able to merge it.

I'd appreciate a CI run of this please.

@edwardneal edwardneal changed the title Port PR 499 to .NET Framework Merge | Port PR 499 to .NET Framework Apr 2, 2025
@cheenamalhotra
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

codecov bot commented Apr 3, 2025

Codecov Report

Attention: Patch coverage is 88.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 66.30%. Comparing base (1247ca4) to head (b132943).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
...etfx/src/Microsoft/Data/SqlClient/SqlDataReader.cs 88.00% 3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (1247ca4) and HEAD (b132943). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (1247ca4) HEAD (b132943)
addons 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3255      +/-   ##
==========================================
- Coverage   72.69%   66.30%   -6.39%     
==========================================
  Files         303      292      -11     
  Lines       59718    59324     -394     
==========================================
- Hits        43414    39337    -4077     
- Misses      16304    19987    +3683     
Flag Coverage Δ
addons ?
netcore 69.02% <ø> (-6.09%) ⬇️
netfx 65.23% <88.00%> (-6.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@mdaigle mdaigle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like basically a 1:1 port and tests pass ✔️

@mdaigle mdaigle self-assigned this Apr 3, 2025
@benrr101 benrr101 merged commit 1690e02 into dotnet:main Apr 7, 2025
123 checks passed
@edwardneal edwardneal deleted the merge/port-pr499 branch April 7, 2025 18:45
This was referenced Jul 25, 2025
This was referenced Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants