Skip to content

Commit 52d6cce

Browse files
better attempt to reproduce
1 parent 7cd2ed3 commit 52d6cce

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

test_elasticsearch/test_dsl/test_integration/_async/test_document.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -631,7 +631,7 @@ async def test_save_without_skip_empty_will_include_empty_fields(
631631
async_write_client: AsyncElasticsearch,
632632
) -> None:
633633
test_repo = Repository(
634-
field_1=[], field_2=None, field_3={}, field_4={"entries": []}, meta={"id": 42}
634+
field_1=[], field_2=None, field_3={}, owner={"name": None}, meta={"id": 42}
635635
)
636636
assert await test_repo.save(index="test-document", skip_empty=False)
637637

@@ -644,7 +644,7 @@ async def test_save_without_skip_empty_will_include_empty_fields(
644644
"field_1": [],
645645
"field_2": None,
646646
"field_3": {},
647-
"field_4": {"entries": []},
647+
"owner": {"name": None},
648648
},
649649
},
650650
await async_write_client.get(index="test-document", id=42),

test_elasticsearch/test_dsl/test_integration/_sync/test_document.py

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -624,15 +624,22 @@ def test_can_save_to_different_index(
624624
def test_save_without_skip_empty_will_include_empty_fields(
625625
write_client: Elasticsearch,
626626
) -> None:
627-
test_repo = Repository(field_1=[], field_2=None, field_3={}, meta={"id": 42})
627+
test_repo = Repository(
628+
field_1=[], field_2=None, field_3={}, owner={"name": None}, meta={"id": 42}
629+
)
628630
assert test_repo.save(index="test-document", skip_empty=False)
629631

630632
assert_doc_equals(
631633
{
632634
"found": True,
633635
"_index": "test-document",
634636
"_id": "42",
635-
"_source": {"field_1": [], "field_2": None, "field_3": {}},
637+
"_source": {
638+
"field_1": [],
639+
"field_2": None,
640+
"field_3": {},
641+
"field_4": {"entries": []},
642+
},
636643
},
637644
write_client.get(index="test-document", id=42),
638645
)

0 commit comments

Comments
 (0)