Fix indentation in multi-line match expressions. Fixes #98 #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
However a couple other tests fail now. Progress!
Elixir is quite flexible wrt syntax around the `->` token. It can follow `do` or `fn`, either on the same line or separately. Because of this, a function that can detect whether it's on the same line as its parent was needed. After adding this function, all tests passed. I'm skeptical about the robustness of this function but it will have to be battle hardened by users reporting bugs.
This time separate the match clauses by a blank line. This test fails.
mattdeboard
added a commit
that referenced
this pull request
Aug 26, 2014
Fix indentation in multi-line match expressions. Fixes #98
mattdeboard
added a commit
that referenced
this pull request
Aug 26, 2014
J3RN
pushed a commit
to J3RN/emacs-elixir
that referenced
this pull request
Apr 24, 2021
…inside update_state/4 to prevent error when checking for stale beam files
J3RN
pushed a commit
to J3RN/emacs-elixir
that referenced
this pull request
Apr 24, 2021
…-fix-timeout-error-stale-beam-files elixir-editors#100 Sets timeout to :infinity for Task.async_stream/3 inside update_…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Future reviewers: For more information about this PR, please read the commit messages in the commits associated with this PR as I tried to be reasonably verbose in each of them where the code was not self-explanatory. Additionally there are in-code comments explaining things I think will be very hard to understand in 6 months without "notes to my future self."