Highlight defstruct and Actor, Base modules #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antifuchs
added a commit
that referenced
this pull request
May 25, 2014
Highlight defstruct and Actor, Base modules
|
Thanks! |
J3RN
pushed a commit
to J3RN/emacs-elixir
that referenced
this pull request
Apr 24, 2021
* Default to dialyxir_long dialyzer format * Test each dialyzer test format Also fix the reporting of diagnostics by using `Task.start_link/1` instead of `spawn/1`. The issue with spawn is that it would start the process outside of the supervision tree. So when we called `GenServer.stop/1` in the test the `ElixirLS.LanguageServer.Server` would stop, which would bring down the `ElixirLS.LanguageServer.Dialyzer` GenServer, but the `ElixirLS.LanguageServer.Dialyzer.Manifest` process would keep running. However, the `ElixirLS.LanguageServer.Dialyzer.Manifest` process depends on an ETS table owned by `ElixirLS.LanguageServer.Dialyzer`, so the ETS calls would start to fail. Using `Task.start_link/1` fixes this because it causes the task to die at the same time that `ElixirLS.LanguageServer.Dialyzer` dies, which means that no process tries to access a non-existant ETS table. * Fix dialyzer format test on Elixir 1.9 * Bump OTP minimum version to 20 This is because the dialyzer implementation relies on `dialyzer_utils:get_core_from_beam/1` which was added in OTP 20 along with the Dbgi chunk in: erlang/otp@dfb899c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.