Remove grammar clause for "fn" terminal. Fixes #7 #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After stepping through SMIE functions with EDebug, I realized the only actual problem in indenting blocks like these is that for the sake of the grammar, `fn` is considered an opener. I tried many ways to get this particular issue sorted out, but the simplest was just to remove that clause from the grammar.
mattdeboard
added a commit
that referenced
this pull request
Jul 5, 2014
Remove grammar clause for "fn" terminal. Fixes #7
J3RN
pushed a commit
to J3RN/emacs-elixir
that referenced
this pull request
Apr 24, 2021
Reference support
J3RN
pushed a commit
to J3RN/emacs-elixir
that referenced
this pull request
Apr 24, 2021
These were deprecated in 1.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After stepping through SMIE functions with EDebug, I realized the only
actual problem in indenting blocks like these is that for the sake of
the grammar,
fnis considered an opener (I think). I tried many ways to get thisparticular issue sorted out, but the simplest was just to remove that
clause from the grammar.