From ccb1e7e49098d1c771e629ada71d5bec7a526ba0 Mon Sep 17 00:00:00 2001 From: Felipe Mesquita Date: Wed, 28 Oct 2020 17:27:43 -0300 Subject: [PATCH 1/2] Fix #9880 Fix formatting error on webpack v5, as described here: #9880 Specifically in [this link](https://webpack.js.org/blog/2020-10-10-webpack-5-release/#minor-changes), on the item that says: Stats json errors and warnings no longer contain strings but objects with information splitted into properties. MIGRATION: Access the information on the properties. i. e. message --- packages/react-dev-utils/formatWebpackMessages.js | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/packages/react-dev-utils/formatWebpackMessages.js b/packages/react-dev-utils/formatWebpackMessages.js index 68afa222817..e28296db5cb 100644 --- a/packages/react-dev-utils/formatWebpackMessages.js +++ b/packages/react-dev-utils/formatWebpackMessages.js @@ -16,8 +16,14 @@ function isLikelyASyntaxError(message) { // Cleans up webpack error messages. function formatMessage(message) { - let lines = message.split('\n'); + let lines = []; + if (typeof message === 'string' || message instanceof String) { + lines = message.split('\n'); + } else if ('message' in Object.keys(message)) { + lines = message['message'].split('\n'); + } + // Strip webpack-added headers off errors/warnings // https://github.com/webpack/webpack/blob/master/lib/ModuleError.js lines = lines.filter(line => !/Module [A-z ]+\(from/.test(line)); From cb8eec5aca572a98bdf47dfe2521c151f7b47d0a Mon Sep 17 00:00:00 2001 From: Felipe Mesquita Date: Tue, 9 Feb 2021 20:12:05 -0300 Subject: [PATCH 2/2] Update packages/react-dev-utils/formatWebpackMessages.js Co-authored-by: Vagner S --- packages/react-dev-utils/formatWebpackMessages.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-dev-utils/formatWebpackMessages.js b/packages/react-dev-utils/formatWebpackMessages.js index e28296db5cb..d6118a74262 100644 --- a/packages/react-dev-utils/formatWebpackMessages.js +++ b/packages/react-dev-utils/formatWebpackMessages.js @@ -20,7 +20,7 @@ function formatMessage(message) { if (typeof message === 'string' || message instanceof String) { lines = message.split('\n'); - } else if ('message' in Object.keys(message)) { + } else if ('message' in message) { lines = message['message'].split('\n'); }