Skip to content

Commit f19371f

Browse files
cipolleschifacebook-github-bot
authored andcommitted
Remove getSurfacePresenter and getModuleRegistry from RCTHost
Summary: This change removes a couple of method from RCTHost which were not following the iOS convention for names. We deprecated them in 0.74 and now that the branch is cut, we can remove them. ## Changelog: [iOS][Breaking] - Remove `getSurfacePresenter` and `getModuleRegistry` from RCTHost Reviewed By: sammy-SC Differential Revision: D56633554 fbshipit-source-id: 88fd1525bfe68ca1f6c2d8403d0dec505a23e9f8
1 parent 94537c7 commit f19371f

File tree

2 files changed

+0
-18
lines changed

2 files changed

+0
-18
lines changed

packages/react-native/ReactCommon/react/runtime/platform/ios/ReactCommon/RCTHost.h

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -77,12 +77,6 @@ typedef std::shared_ptr<facebook::react::JSRuntimeFactory> (^RCTHostJSEngineProv
7777

7878
- (RCTFabricSurface *)createSurfaceWithModuleName:(NSString *)moduleName initialProperties:(NSDictionary *)properties;
7979

80-
- (RCTSurfacePresenter *)getSurfacePresenter __attribute__((deprecated("Use `surfacePresenter` property instead.")));
81-
82-
// Native module API
83-
84-
- (RCTModuleRegistry *)getModuleRegistry __attribute__((deprecated("Use `moduleRegistry` property instead.")));
85-
8680
@end
8781

8882
NS_ASSUME_NONNULL_END

packages/react-native/ReactCommon/react/runtime/platform/ios/ReactCommon/RCTHost.mm

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -289,23 +289,11 @@ - (RCTModuleRegistry *)moduleRegistry
289289
return _moduleRegistry;
290290
}
291291

292-
// Deprecated
293-
- (RCTModuleRegistry *)getModuleRegistry
294-
{
295-
return self.moduleRegistry;
296-
}
297-
298292
- (RCTSurfacePresenter *)surfacePresenter
299293
{
300294
return [_instance surfacePresenter];
301295
}
302296

303-
// Deprecated
304-
- (RCTSurfacePresenter *)getSurfacePresenter
305-
{
306-
return self.surfacePresenter;
307-
}
308-
309297
- (void)callFunctionOnJSModule:(NSString *)moduleName method:(NSString *)method args:(NSArray *)args
310298
{
311299
[_instance callFunctionOnJSModule:moduleName method:method args:args];

0 commit comments

Comments
 (0)