Skip to content

Commit aad3da8

Browse files
Remove VisibleForTesting from SDK production code (#7103)
Some methods are currently marked with `@VisibleForTestingOnly` but are being used directly within the SDK code. This annotation is intended to restrict usage to tests, and its presence causes errors when integrating the SDK into internal systems via copybara. Internal Tracking: b/429425834
1 parent 696f021 commit aad3da8

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

firebase-config/src/main/java/com/google/firebase/remoteconfig/internal/ConfigFetchHandler.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ public class ConfigFetchHandler {
7777
*
7878
* <p>Defined here since {@link HttpURLConnection} does not provide this code.
7979
*/
80-
@VisibleForTesting static final int HTTP_TOO_MANY_REQUESTS = 429;
80+
static final int HTTP_TOO_MANY_REQUESTS = 429;
8181

8282
/**
8383
* First-open time key name in GA user-properties. First-open time is a predefined user-dimension

firebase-config/src/main/java/com/google/firebase/remoteconfig/internal/ConfigSharedPrefsClient.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -373,7 +373,6 @@ Date getBackoffEndTime() {
373373
// Realtime exponential backoff logic.
374374
// -----------------------------------------------------------------
375375

376-
@VisibleForTesting
377376
public RealtimeBackoffMetadata getRealtimeBackoffMetadata() {
378377
synchronized (realtimeBackoffMetadataLock) {
379378
return new RealtimeBackoffMetadata(
@@ -394,7 +393,6 @@ void setRealtimeBackoffMetadata(int numFailedStreams, Date backoffEndTime) {
394393
}
395394
}
396395

397-
@VisibleForTesting
398396
public void setRealtimeBackoffEndTime(Date backoffEndTime) {
399397
synchronized (realtimeBackoffMetadataLock) {
400398
frcSharedPrefs
@@ -415,7 +413,6 @@ void resetRealtimeBackoff() {
415413
* <p>The purpose of this class is to avoid race conditions when retrieving backoff metadata
416414
* values separately.
417415
*/
418-
@VisibleForTesting
419416
public static class RealtimeBackoffMetadata {
420417
private int numFailedStreams;
421418
private Date backoffEndTime;

0 commit comments

Comments
 (0)