From e2ea9f62063208d212aa0ddc23c1950d50bca13b Mon Sep 17 00:00:00 2001 From: Eric Kalosa-Kenyon Date: Sun, 10 Sep 2023 22:31:05 -0400 Subject: [PATCH 1/2] logging.warning doesn't allow null positional (nor keyword) args --- src/firebase_functions/private/util.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/firebase_functions/private/util.py b/src/firebase_functions/private/util.py index 0dd2eaa..5ace292 100644 --- a/src/firebase_functions/private/util.py +++ b/src/firebase_functions/private/util.py @@ -143,7 +143,7 @@ def _on_call_valid_content_type(request: _Request) -> bool: content_type: str | None = request.headers.get("Content-Type") if content_type is None: - _logging.warning("Request is missing Content-Type.", content_type) + _logging.warning("Request is missing Content-Type.") return False # If it has a charset, just ignore it for now. From d2655d6647f96de7cafc7657a2a477af10e556b9 Mon Sep 17 00:00:00 2001 From: Eric Kalosa-Kenyon Date: Sun, 10 Sep 2023 22:45:29 -0400 Subject: [PATCH 2/2] clarified logic around another potential None arg in a logging call --- src/firebase_functions/private/util.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/firebase_functions/private/util.py b/src/firebase_functions/private/util.py index 5ace292..e18525a 100644 --- a/src/firebase_functions/private/util.py +++ b/src/firebase_functions/private/util.py @@ -114,7 +114,7 @@ def _on_call_valid_body(request: _Request) -> bool: return False # The body must have data. - if request.json is None or "data" not in request.json: + if "data" not in request.json: _logging.warning("Request body is missing data.", request.json) return False