-
Notifications
You must be signed in to change notification settings - Fork 213
feat: disable error logging stacktrace in message #1705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CorieW
wants to merge
6
commits into
master
Choose a base branch
from
@invertase/add-disable-error-traceback
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
243c6b1
feat: disable error logging stacktrace in message
CorieW 06e2743
feat: disable error logging stacktrace in message
CorieW ef1e958
fix: improvements based on feedback
CorieW 555f420
Merge branch '@invertase/add-disable-error-traceback' of https://gith…
CorieW 0b3e916
feat: add default behaviour test
CorieW 17f89c7
fix: duplicate getGlobalOptions
CorieW File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,8 @@ | ||
import { expect } from "chai"; | ||
|
||
import * as logger from "../src/logger"; | ||
import { setGlobalOptions } from "../src/v2"; | ||
import { getGlobalOptions } from "../src/v2/options"; | ||
|
||
describe("logger", () => { | ||
const stdoutWrite = process.stdout.write.bind(process.stdout); | ||
|
@@ -218,4 +220,47 @@ describe("logger", () => { | |
}); | ||
}); | ||
}); | ||
|
||
describe("error logging stacktrace", () => { | ||
const defaultOptions = getGlobalOptions(); | ||
|
||
beforeEach(() => { | ||
setGlobalOptions(defaultOptions); | ||
}); | ||
|
||
afterEach(() => { | ||
setGlobalOptions(defaultOptions); | ||
}); | ||
Comment on lines
+227
to
+233
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
||
it("default behavior is to include stacktrace in error logs", () => { | ||
// If this test fails, it means there's a breaking change. | ||
const message = "Test error with stacktrace"; | ||
logger.error(message); | ||
const messageOutput = JSON.parse(lastErr.trim()).message; | ||
expect(messageOutput).to.include(`Error: ${message}`); | ||
}); | ||
|
||
it("when disableErrorLoggingStacktrace is set to false, should include stacktrace in error logs", () => { | ||
const message = "Test error with stacktrace"; | ||
setGlobalOptions({ | ||
disableErrorLoggingStacktrace: false, | ||
}); | ||
logger.error(message); | ||
const messageOutput = JSON.parse(lastErr.trim()).message; | ||
|
||
expect(messageOutput).to.include(`Error: ${message}`); | ||
}); | ||
|
||
it("when disableErrorLoggingStacktrace is set to true, should not include stacktrace in error logs", () => { | ||
const message = "Test error with stacktrace disabled"; | ||
setGlobalOptions({ | ||
disableErrorLoggingStacktrace: true, | ||
}); | ||
logger.error(message); | ||
expectStderr({ | ||
severity: "ERROR", | ||
message: message, | ||
}); | ||
}); | ||
}); | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -232,6 +232,15 @@ export interface GlobalOptions { | |
* may inadvertently be wiped out. | ||
*/ | ||
preserveExternalChanges?: boolean; | ||
|
||
/** | ||
* Controls whether error logging should include the stacktrace of the error automatically. | ||
* Defaults to false. | ||
* | ||
Comment on lines
+238
to
+239
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
* @remarks | ||
* When true, the error message will not include the stacktrace of the error. | ||
*/ | ||
disableErrorLoggingStacktrace?: boolean; | ||
} | ||
|
||
let globalOptions: GlobalOptions | undefined; | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.