Deploying to stdlib-fpm from @ 42182b0 🚀

Author: perazz

src/stdlib_linalg_determinant.f90

@@ -220,7 +220,7 @@ module function stdlib_linalg_rspdeterminant(a,overwrite_a,err) result(det)
                        err0 = linalg_state_type(this,LINALG_INTERNAL_ERROR,'catastrophic error')
                 end select
 
-                if (.not.copy_a) deallocate(amat)
+                if (copy_a) deallocate(amat)
 
          end select
 
@@ -437,7 +437,7 @@ module function stdlib_linalg_rdpdeterminant(a,overwrite_a,err) result(det)
                        err0 = linalg_state_type(this,LINALG_INTERNAL_ERROR,'catastrophic error')
                 end select
 
-                if (.not.copy_a) deallocate(amat)
+                if (copy_a) deallocate(amat)
 
          end select
 
@@ -654,7 +654,7 @@ module function stdlib_linalg_cspdeterminant(a,overwrite_a,err) result(det)
                        err0 = linalg_state_type(this,LINALG_INTERNAL_ERROR,'catastrophic error')
                 end select
 
-                if (.not.copy_a) deallocate(amat)
+                if (copy_a) deallocate(amat)
 
          end select
 
@@ -871,7 +871,7 @@ module function stdlib_linalg_cdpdeterminant(a,overwrite_a,err) result(det)
                        err0 = linalg_state_type(this,LINALG_INTERNAL_ERROR,'catastrophic error')
                 end select
 
-                if (.not.copy_a) deallocate(amat)
+                if (copy_a) deallocate(amat)
 
          end select
 

test/test_linalg_determinant.f90

@@ -42,6 +42,7 @@ subroutine test_rsp_eye_determinant(error)
         integer(ilp), parameter :: n = 128_ilp
 
         real(sp) :: a(n,n),deta
+        real(sp), allocatable :: aalloc(:,:)
 
         a = eye(n)
 
@@ -50,8 +51,18 @@ subroutine test_rsp_eye_determinant(error)
 
         call check(error,state%ok(),state%print())
         if (allocated(error)) return
-        
         call check(error, abs(deta-1.0_sp)<epsilon(0.0_sp), 'det(eye(n))==1')
+        if (allocated(error)) return
+
+        !> Test with allocatable matrix
+        aalloc = eye(n)
+        deta = det(aalloc,overwrite_a=.false.,err=state)
+        call check(error,state%ok(),state%print()//' (allocatable a)')
+        if (allocated(error)) return
+        call check(error,allocated(aalloc),'a is still allocated')
+        if (allocated(error)) return
+        call check(error, abs(deta-1.0_sp)<epsilon(0.0_sp), 'det(eye(n))==1 (allocatable a))')
+        if (allocated(error)) return
 
     end subroutine test_rsp_eye_determinant
 
@@ -91,6 +102,7 @@ subroutine test_rdp_eye_determinant(error)
         integer(ilp), parameter :: n = 128_ilp
 
         real(dp) :: a(n,n),deta
+        real(dp), allocatable :: aalloc(:,:)
 
         a = eye(n)
 
@@ -99,8 +111,18 @@ subroutine test_rdp_eye_determinant(error)
 
         call check(error,state%ok(),state%print())
         if (allocated(error)) return
-        
         call check(error, abs(deta-1.0_dp)<epsilon(0.0_dp), 'det(eye(n))==1')
+        if (allocated(error)) return
+
+        !> Test with allocatable matrix
+        aalloc = eye(n)
+        deta = det(aalloc,overwrite_a=.false.,err=state)
+        call check(error,state%ok(),state%print()//' (allocatable a)')
+        if (allocated(error)) return
+        call check(error,allocated(aalloc),'a is still allocated')
+        if (allocated(error)) return
+        call check(error, abs(deta-1.0_dp)<epsilon(0.0_dp), 'det(eye(n))==1 (allocatable a))')
+        if (allocated(error)) return
 
     end subroutine test_rdp_eye_determinant
 
@@ -140,6 +162,7 @@ subroutine test_csp_eye_determinant(error)
         integer(ilp), parameter :: n = 128_ilp
 
         complex(sp) :: a(n,n),deta
+        complex(sp), allocatable :: aalloc(:,:)
 
         a = eye(n)
 
@@ -148,8 +171,18 @@ subroutine test_csp_eye_determinant(error)
 
         call check(error,state%ok(),state%print())
         if (allocated(error)) return
-        
         call check(error, abs(deta-1.0_sp)<epsilon(0.0_sp), 'det(eye(n))==1')
+        if (allocated(error)) return
+
+        !> Test with allocatable matrix
+        aalloc = eye(n)
+        deta = det(aalloc,overwrite_a=.false.,err=state)
+        call check(error,state%ok(),state%print()//' (allocatable a)')
+        if (allocated(error)) return
+        call check(error,allocated(aalloc),'a is still allocated')
+        if (allocated(error)) return
+        call check(error, abs(deta-1.0_sp)<epsilon(0.0_sp), 'det(eye(n))==1 (allocatable a))')
+        if (allocated(error)) return
 
     end subroutine test_csp_eye_determinant
 
@@ -189,6 +222,7 @@ subroutine test_cdp_eye_determinant(error)
         integer(ilp), parameter :: n = 128_ilp
 
         complex(dp) :: a(n,n),deta
+        complex(dp), allocatable :: aalloc(:,:)
 
         a = eye(n)
 
@@ -197,8 +231,18 @@ subroutine test_cdp_eye_determinant(error)
 
         call check(error,state%ok(),state%print())
         if (allocated(error)) return
-        
         call check(error, abs(deta-1.0_dp)<epsilon(0.0_dp), 'det(eye(n))==1')
+        if (allocated(error)) return
+
+        !> Test with allocatable matrix
+        aalloc = eye(n)
+        deta = det(aalloc,overwrite_a=.false.,err=state)
+        call check(error,state%ok(),state%print()//' (allocatable a)')
+        if (allocated(error)) return
+        call check(error,allocated(aalloc),'a is still allocated')
+        if (allocated(error)) return
+        call check(error, abs(deta-1.0_dp)<epsilon(0.0_dp), 'det(eye(n))==1 (allocatable a))')
+        if (allocated(error)) return
 
     end subroutine test_cdp_eye_determinant