Skip to content

Commit 8cb1708

Browse files
authored
Merge pull request #1 from geopozo/david/fix-c2m-scatter
David/fix c2m scatter
2 parents 56f2ebc + f4d3f01 commit 8cb1708

File tree

4 files changed

+113
-75
lines changed

4 files changed

+113
-75
lines changed

devtools/test_dashboard/list.html

Lines changed: 51 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,51 @@
1+
<!DOCTYPE html>
2+
<html lang="en">
3+
<head>
4+
<meta charset="UTF-8" />
5+
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
6+
<title>Supported Charts</title>
7+
</head>
8+
9+
<body>
10+
<h1>Supported Charts</h1>
11+
<div id="links"></div>
12+
13+
<script>
14+
const URI = "http://localhost:3000/devtools/test_dashboard/index.html";
15+
const divLinks = document.getElementById("links");
16+
const links = [
17+
"line_scatter",
18+
"line_scatter_change_side",
19+
"line_scatter_change_side_shrunk",
20+
"line_scatter_regular_side",
21+
"line_scatter_regular_side_shrunk",
22+
"scatter_errorbars_inherit_color",
23+
"scatter_fill_corner_cases",
24+
"scatter_fill_gradient_tonext",
25+
"scatter_fill_gradient_tonexty_toself",
26+
"scatter_fill_no_opacity",
27+
"scatter_fill_pattern",
28+
"scatter_fill_self_next",
29+
"scatter_fill_self_opacity",
30+
"grouped_scatter-linear",
31+
"axes_category_categoryarray",
32+
"axes_category_descending",
33+
"axes_category_descending_with_gaps",
34+
"axes_category_null",
35+
"tick_attributes",
36+
];
37+
38+
links.forEach((chart) => {
39+
const a = document.createElement("a");
40+
a.href = `${URI}#${chart}`;
41+
a.textContent = chart;
42+
a.target = "_blank";
43+
44+
const br = document.createElement("br");
45+
46+
divLinks.appendChild(a);
47+
divLinks.appendChild(br);
48+
});
49+
</script>
50+
</body>
51+
</html>

package-lock.json

Lines changed: 56 additions & 69 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,12 +72,13 @@
7272
"@plotly/d3-sankey": "0.7.2",
7373
"@plotly/d3-sankey-circular": "0.33.1",
7474
"@plotly/mapbox-gl": "1.13.4",
75+
"@plotly/regl": "^2.1.2",
7576
"@turf/area": "^7.1.0",
7677
"@turf/bbox": "^7.1.0",
7778
"@turf/centroid": "^7.1.0",
7879
"base64-arraybuffer": "^1.0.2",
7980
"canvas-fit": "^1.5.0",
80-
"chart2music": "^1.13.0",
81+
"chart2music": "^1.19.0",
8182
"color-alpha": "1.0.4",
8283
"color-normalize": "1.5.0",
8384
"color-parse": "2.0.0",
@@ -108,7 +109,6 @@
108109
"point-in-polygon": "^1.1.0",
109110
"polybooljs": "^1.2.2",
110111
"probe-image-size": "^7.2.3",
111-
"@plotly/regl": "^2.1.2",
112112
"regl-error2d": "^2.0.12",
113113
"regl-line2d": "^3.1.3",
114114
"regl-scatter2d": "^3.3.1",
@@ -125,6 +125,8 @@
125125
},
126126
"devDependencies": {
127127
"@biomejs/biome": "1.8.3",
128+
"@plotly/mathjax-v2": "npm:[email protected]",
129+
"@plotly/mathjax-v3": "npm:mathjax@^3.2.2",
128130
"amdefine": "^1.0.1",
129131
"assert": "^2.1.0",
130132
"browserify-transform-tools": "^1.7.0",
@@ -162,8 +164,6 @@
162164
"karma-viewport": "1.0.2",
163165
"lodash": "^4.17.21",
164166
"madge": "^8.0.0",
165-
"@plotly/mathjax-v2": "npm:[email protected]",
166-
"@plotly/mathjax-v3": "npm:mathjax@^3.2.2",
167167
"minify-stream": "^2.1.0",
168168
"npm-link-check": "^5.0.1",
169169
"open": "^8.4.2",

src/plot_api/plot_config.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -465,10 +465,10 @@ var configAttributes = {
465465
sonification: {
466466
valType: 'any',
467467
dflt: {
468-
enabled: false,
468+
enabled: true,
469469
options: {},
470470
info: {},
471-
closedCaptions: {generate: false, elId: 'c2m-plotly-cc', elClassname: 'c2m-plotly-closed_captions'}
471+
closedCaptions: {generate: true, elId: 'c2m-plotly-cc', elClassname: 'c2m-plotly-closed_captions'}
472472
},
473473
description: ['Sonification options: whether to enable, options to pass to the library, info to pass to the library, closedCaptions to control how plotly renders the closed-captions element.',
474474
'chart2music is supported and options here include Options and Info from https://www.chart2music.com/docs/API/Config. '

0 commit comments

Comments
 (0)