build: remove nursery biome rules

Author: anonrig

.eslintrc.js

@@ -25,13 +25,23 @@ module.exports = {
     tick: true,
     jest: true,
   },
+  parserOptions: {
+    EXPERIMENTAL_useProjectService: true,
+  },
   rules: {
     'react-hooks/exhaustive-deps': [
       'warn',
       {additionalHooks: ADDITIONAL_HOOKS_TO_CHECK_DEPS_FOR},
     ],
     ...(!isRelaxed && !isCi ? strictRulesNotCi : {}),
 
+    // TODO(@anonrig): Move this to eslint-config-sentry-app
+    '@typescript-eslint/consistent-type-imports': [
+      'error',
+      {fixStyle: 'separate-type-imports', prefer: 'type-imports'},
+    ],
+    '@typescript-eslint/consistent-type-exports': ['error'],
+
     // TODO(@anonrig): Remove these rules from eslint-sentry-config.
     'import/no-nodejs-modules': 'off',
     semi: 'off',
@@ -54,6 +64,17 @@ module.exports = {
   // and formatting these files.
   ignorePatterns: ['*.json'],
   overrides: [
+    {
+      // Benchmarks are not compiled with the same tsconfig as the rest of the
+      // app, so we need to disable some rules.
+      files: ['static/app/**/*.benchmark.ts'],
+      parserOptions: {
+        project: false,
+      },
+      rules: {
+        '@typescript-eslint/consistent-type-exports': 'off',
+      },
+    },
     {
       files: ['tests/js/**/*.{ts,js}'],
       extends: ['plugin:testing-library/react', 'sentry-app/strict'],

biome.json

@@ -26,9 +26,7 @@
       },
       "nursery": {
         "noDuplicateJsonKeys": "error",
-        "noNodejsModules": "error",
-        "useExportType": "error",
-        "useImportType": "error"
+        "noNodejsModules": "error"
       },
       "suspicious": {
         "noDebugger": "error",

static/app/components/alerts/onDemandMetricAlert.tsx

@@ -1,4 +1,3 @@
-import type React from 'react';
 import styled from '@emotion/styled';
 
 import Alert from 'sentry/components/alert';

static/app/components/dropdownAutoComplete/index.tsx

@@ -1,4 +1,3 @@
-import type React from 'react';
 import {useCallback, useState} from 'react';
 import styled from '@emotion/styled';
 

static/app/components/events/eventStatisticalDetector/transactionsDeltaProvider.tsx

@@ -1,4 +1,3 @@
-import type React from 'react';
 import {createContext, useContext} from 'react';
 
 import {RELATIVE_DAYS_WINDOW} from 'sentry/components/events/eventStatisticalDetector/consts';

static/app/components/events/interfaces/crashContent/exception/actionableItems.tsx

@@ -1,4 +1,3 @@
-import type React from 'react';
 import {Fragment, useEffect, useMemo, useState} from 'react';
 import styled from '@emotion/styled';
 import startCase from 'lodash/startCase';

static/app/components/profiling/flamegraph/deprecatedAggregateFlamegraph.tsx

@@ -1,5 +1,4 @@
 import type {ReactElement} from 'react';
-import type React from 'react';
 import {Fragment, useEffect, useLayoutEffect, useMemo, useState} from 'react';
 import styled from '@emotion/styled';
 import * as Sentry from '@sentry/react';

static/app/components/profiling/flamegraph/flamegraphDrawer/flamegraphTreeTable.tsx

@@ -1,4 +1,3 @@
-import type React from 'react';
 import {useCallback, useEffect, useMemo, useState} from 'react';
 import styled from '@emotion/styled';
 

static/app/utils/onDemandMetrics/index.tsx

@@ -1,5 +1,3 @@
-import type React from 'react';
-
 import type {ParseResult, TokenResult} from 'sentry/components/searchSyntax/parser';
 import {parseSearch, Token} from 'sentry/components/searchSyntax/parser';
 import type {FieldKey} from 'sentry/utils/fields';

static/app/utils/performance/contexts/pageAlert.tsx

@@ -1,4 +1,3 @@
-import type React from 'react';
 import {createContext, Fragment, useContext, useState} from 'react';
 import type {Theme} from '@emotion/react';