Skip to content

Commit e15166e

Browse files
authored
Merge pull request #1097 from timvaillancourt/remove-eol-5.5
Remove end-of-life MySQL 5.5.x version
2 parents d3ea39c + 31f3ac0 commit e15166e

File tree

21 files changed

+12
-21
lines changed

21 files changed

+12
-21
lines changed

.github/workflows/replica-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ jobs:
88
runs-on: ubuntu-latest
99
strategy:
1010
matrix:
11-
version: [mysql-5.5.62,mysql-5.6.43,mysql-5.7.25,mysql-8.0.16]
11+
version: [mysql-5.6.43,mysql-5.7.25,mysql-8.0.16]
1212

1313
steps:
1414
- uses: actions/checkout@v2

doc/requirements-and-limitations.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
### Requirements
44

5+
- `gh-ost` currently requires MySQL versions 5.6 and greater.
6+
57
- You will need to have one server serving Row Based Replication (RBR) format binary logs. Right now `FULL` row image is supported. `MINIMAL` to be supported in the near future. `gh-ost` prefers to work with replicas. You may [still have your master configured with Statement Based Replication](migrating-with-sbr.md) (SBR).
68

79
- If you are using a replica, the table must have an identical schema between the master and replica.

go/logic/inspect.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -364,8 +364,7 @@ func (this *Inspector) validateBinlogs() error {
364364
}
365365
query = `select @@global.binlog_row_image`
366366
if err := this.db.QueryRow(query).Scan(&this.migrationContext.OriginalBinlogRowImage); err != nil {
367-
// Only as of 5.6. We wish to support 5.5 as well
368-
this.migrationContext.OriginalBinlogRowImage = "FULL"
367+
return err
369368
}
370369
this.migrationContext.OriginalBinlogRowImage = strings.ToUpper(this.migrationContext.OriginalBinlogRowImage)
371370
if this.migrationContext.OriginalBinlogRowImage != "FULL" {

localtests/datetime-submillis-zeroleading/ignore_versions

Lines changed: 0 additions & 1 deletion
This file was deleted.

localtests/datetime-submillis/ignore_versions

Lines changed: 0 additions & 1 deletion
This file was deleted.

localtests/datetime-to-timestamp-pk-fail/ignore_versions

Lines changed: 0 additions & 1 deletion
This file was deleted.

localtests/datetime/ignore_versions

Lines changed: 0 additions & 1 deletion
This file was deleted.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
(5.5|5.6)
1+
(5.6)
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
(5.5|5.6)
1+
(5.6)
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
(5.5|5.6)
1+
(5.6)
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
(5.5|5.6)
1+
(5.6)

localtests/geometry57/ignore_versions

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
(5.5|5.6)
1+
(5.6)

localtests/json57/ignore_versions

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
(5.5|5.6)
1+
(5.6)

localtests/json57dml/ignore_versions

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
(5.5|5.6)
1+
(5.6)

localtests/spatial57/ignore_versions

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
(5.5|5.6)
1+
(5.6)

localtests/swap-pk-uk/ignore_versions

Lines changed: 0 additions & 1 deletion
This file was deleted.

localtests/swap-uk-uk/ignore_versions

Lines changed: 0 additions & 1 deletion
This file was deleted.

localtests/timestamp-to-datetime/ignore_versions

Lines changed: 0 additions & 1 deletion
This file was deleted.

localtests/timestamp/ignore_versions

Lines changed: 0 additions & 1 deletion
This file was deleted.

localtests/tz-datetime-ts/ignore_versions

Lines changed: 0 additions & 1 deletion
This file was deleted.

localtests/tz/ignore_versions

Lines changed: 0 additions & 1 deletion
This file was deleted.

0 commit comments

Comments
 (0)