From 2eff4fea1f7d1bbd7338da66947f020967c17331 Mon Sep 17 00:00:00 2001 From: Aravind Parappil Date: Wed, 22 Jan 2025 18:46:16 -0600 Subject: [PATCH] fix: prevent default filters from getting overwritten Clear Filters button was not unchecking selected filters because of a reference between settings and defaultSettings. i.e., whenever filters changed, the filter reasons in the defaultFilters object also changed, which is not desirable. Using the spread operator to get selected filters fixes this issue --- src/renderer/routes/Filters.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/renderer/routes/Filters.tsx b/src/renderer/routes/Filters.tsx index c6c03b3f1..9996608f3 100644 --- a/src/renderer/routes/Filters.tsx +++ b/src/renderer/routes/Filters.tsx @@ -22,7 +22,7 @@ export const FiltersRoute: FC = () => { const { settings, clearFilters, updateSetting } = useContext(AppContext); const updateReasonFilter = (reason: Reason, checked: boolean) => { - let reasons: Reason[] = settings.filterReasons; + let reasons: Reason[] = [...settings.filterReasons]; if (checked) { reasons.push(reason);