diff --git a/package.json b/package.json index 91d581adc..c78e5c03c 100644 --- a/package.json +++ b/package.json @@ -152,7 +152,6 @@ "@testing-library/react": "16.2.0", "@types/jest": "29.5.14", "@types/node": "22.12.0", - "@types/nprogress": "0.2.3", "@types/react": "19.0.8", "@types/react-dom": "19.0.3", "@types/react-router-dom": "5.3.3", @@ -174,7 +173,6 @@ "jest-environment-jsdom": "29.7.0", "mini-css-extract-plugin": "2.9.2", "nock": "13.5.6", - "nprogress": "0.2.0", "postcss": "8.5.1", "postcss-loader": "8.1.1", "rimraf": "6.0.1", diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 384d957b4..0ad1a5e5a 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -63,9 +63,6 @@ importers: '@types/node': specifier: 22.12.0 version: 22.12.0 - '@types/nprogress': - specifier: 0.2.3 - version: 0.2.3 '@types/react': specifier: 19.0.8 version: 19.0.8 @@ -129,9 +126,6 @@ importers: nock: specifier: 13.5.6 version: 13.5.6 - nprogress: - specifier: 0.2.0 - version: 0.2.0 postcss: specifier: 8.5.1 version: 8.5.1 @@ -960,9 +954,6 @@ packages: '@types/node@22.12.0': resolution: {integrity: sha512-Fll2FZ1riMjNmlmJOdAyY5pUbkftXslB5DgEzlIuNaiWhXd00FhWxVC/r4yV/4wBb9JfImTu+jiSvXTkJ7F/gA==} - '@types/nprogress@0.2.3': - resolution: {integrity: sha512-k7kRA033QNtC+gLc4VPlfnue58CM1iQLgn1IMAU8VPHGOj7oIHPp9UlhedEnD/Gl8evoCjwkZjlBORtZ3JByUA==} - '@types/plist@3.0.5': resolution: {integrity: sha512-E6OCaRmAe4WDmWNsL/9RMqdkkzDCY1etutkflWk4c+AcjDU07Pcz1fQwTX0TQz+Pxqn9i4L1TU3UFpjnrcDgxA==} @@ -3214,9 +3205,6 @@ packages: engines: {node: ^12.13.0 || ^14.15.0 || >=16.0.0} deprecated: This package is no longer supported. - nprogress@0.2.0: - resolution: {integrity: sha512-I19aIingLgR1fmhftnbWWO3dXc0hSxqHQHQb3H8m+K3TnEn/iSeTZZOyvKXWqQESMwuUVnatlCnZdLBZZt2VSA==} - nth-check@2.1.1: resolution: {integrity: sha512-lqjrjmaOoAnWfMmBPL+XNnynZh2+swxiX3WUE0s4yEHI6m+AwrK2UZOimIRl3X/4QctVqS8AiZjFqyOGrMXb/w==} @@ -5429,8 +5417,6 @@ snapshots: dependencies: undici-types: 6.20.0 - '@types/nprogress@0.2.3': {} - '@types/plist@3.0.5': dependencies: '@types/node': 22.12.0 @@ -8193,8 +8179,6 @@ snapshots: gauge: 4.0.4 set-blocking: 2.0.0 - nprogress@0.2.0: {} - nth-check@2.1.1: dependencies: boolbase: 1.0.0 diff --git a/src/renderer/App.tsx b/src/renderer/App.tsx index d3ad42080..e5fd97f52 100644 --- a/src/renderer/App.tsx +++ b/src/renderer/App.tsx @@ -9,7 +9,6 @@ import { import { BaseStyles, Box, ThemeProvider } from '@primer/react'; -import { Loading } from './components/Loading'; import { Sidebar } from './components/Sidebar'; import { AppContext, AppProvider } from './context/App'; import { AccountsRoute } from './routes/Accounts'; @@ -40,7 +39,6 @@ export const App = () => { - ({ - configure: jest.fn(), - start: jest.fn(), - done: jest.fn(), - remove: jest.fn(), -})); - -describe('renderer/components/Loading.tsx', () => { - beforeEach(() => { - jest.clearAllMocks(); - }); - - it('should check that NProgress is getting called in when status changes (loading)', () => { - const { container } = render( - - - , - ); - - expect(container.innerHTML).toBe(''); - expect(NProgress.configure).toHaveBeenCalledTimes(1); - expect(NProgress.start).toHaveBeenCalledTimes(1); - }); - - it('should check that NProgress is getting called in when status changes (not loading)', () => { - const { container } = render( - - - , - ); - - expect(container.innerHTML).toBe(''); - expect(NProgress.configure).toHaveBeenCalledTimes(1); - expect(NProgress.done).toHaveBeenCalledTimes(1); - }); - - it('should remove NProgress on unmount', () => { - const { unmount } = render( - - - , - ); - expect(NProgress.remove).toHaveBeenCalledTimes(0); - unmount(); - expect(NProgress.remove).toHaveBeenCalledTimes(1); - }); -}); diff --git a/src/renderer/components/Loading.tsx b/src/renderer/components/Loading.tsx deleted file mode 100644 index 882f085be..000000000 --- a/src/renderer/components/Loading.tsx +++ /dev/null @@ -1,29 +0,0 @@ -import { type FC, useContext, useEffect } from 'react'; - -import NProgress from 'nprogress'; - -import { AppContext } from '../context/App'; - -export const Loading: FC = () => { - const { status } = useContext(AppContext); - - useEffect(() => { - NProgress.configure({ - showSpinner: false, - }); - - return () => { - NProgress.remove(); - }; - }, []); - - useEffect(() => { - if (status === 'loading') { - NProgress.start(); - } else { - NProgress.done(); - } - }, [status]); - - return null; -}; diff --git a/src/renderer/components/fields/RadioGroup.test.tsx b/src/renderer/components/fields/RadioGroup.test.tsx index b55091935..eeb2ba652 100644 --- a/src/renderer/components/fields/RadioGroup.test.tsx +++ b/src/renderer/components/fields/RadioGroup.test.tsx @@ -1,4 +1,4 @@ -import { fireEvent, render, screen } from '@testing-library/react'; +import { render } from '@testing-library/react'; import { type IRadioGroup, RadioGroup } from './RadioGroup'; describe('renderer/components/fields/RadioGroup.tsx', () => { @@ -24,12 +24,4 @@ describe('renderer/components/fields/RadioGroup.tsx', () => { const tree = render(); expect(tree).toMatchSnapshot(); }); - - it('should check that NProgress is getting called in getDerivedStateFromProps (loading)', () => { - render(); - - fireEvent.click(screen.getByLabelText('Value 1')); - - expect(props.onChange).toHaveBeenCalledTimes(1); - }); }); diff --git a/src/renderer/index.tsx b/src/renderer/index.tsx index 08a30d9c4..eb9593a05 100644 --- a/src/renderer/index.tsx +++ b/src/renderer/index.tsx @@ -1,6 +1,5 @@ import { createRoot } from 'react-dom/client'; -import 'nprogress/nprogress.css'; import { App } from './App'; const container = document.getElementById('root');