Skip to content

Commit b26d072

Browse files
committed
adds comments at problematic spots in the code
1 parent b9ed1f6 commit b26d072

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

godot-core/src/meta/param_tuple/impls.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,13 +60,15 @@ macro_rules! unsafe_impl_param_tuple {
6060
$(
6161
// SAFETY: `args_ptr` is an array with length `Self::LEN` and each element is a valid pointer, since they
6262
// are all reborrowable as references.
63+
// no-commit: False with default parameters, should we change this?
6364
unsafe { *args_ptr.offset($n) },
6465
)*
6566
);
6667

6768
let param_tuple = (
6869
$(
6970
// SAFETY: Each pointer in `args_ptr` is reborrowable as a `&Variant` for the duration of this call.
71+
// no-commit: False with default parameters, should we change this?
7072
unsafe { varcall_arg::<$P>(args.$n, call_ctx, $n)? },
7173
)*
7274
);

godot-core/src/meta/signature.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@ impl<Params: InParamTuple, Ret: ToGodot> Signature<Params, Ret> {
7878
trace::push(true, false, call_ctx);
7979

8080
// SAFETY: TODO.
81+
// no-commit: problem with default args here!
8182
let args = unsafe { Params::from_varcall_args(args_ptr, call_ctx)? };
8283

8384
let rust_result = unsafe { func(instance_ptr, args) };

0 commit comments

Comments
 (0)