Merge pull request #3787 from codeinred:fix-quickstart

copybara-github · copybara-github · commit 78aa2ba4401a · 2022-07-11T12:23:26.000-07:00
PiperOrigin-RevId: 460272863
Change-Id: I139e31faca4dab6f697e0cd1b3491f791fda5f8a
diff --git a/docs/quickstart-cmake.md b/docs/quickstart-cmake.md
@@ -58,7 +58,8 @@ set(CMAKE_CXX_STANDARD 14)
 include(FetchContent)
 FetchContent_Declare(
   googletest
-  URL https://github.com/google/googletest/archive/609281088cfefc76f9d0ce82e1ff6c30cc3591e5.zip
+  GIT_REPOSITORY https://github.com/google/googletest.git
+  GIT_TAG release-1.12.1
 )
 # For Windows: Prevent overriding the parent project's compiler/linker settings
 set(gtest_force_shared_crt ON CACHE BOOL "" FORCE)
@@ -108,7 +109,7 @@ add_executable(
 )
 target_link_libraries(
   hello_test
-  gtest_main
+  GTest::gtest_main
 )
 
 include(GoogleTest)

Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,8 @@ set(CMAKE_CXX_STANDARD 14)`
`58`	`58`	`include(FetchContent)`
`59`	`59`	`FetchContent_Declare(`
`60`	`60`	`googletest`
`61`		`- URL https://github.com/google/googletest/archive/609281088cfefc76f9d0ce82e1ff6c30cc3591e5.zip`
	`61`	`+ GIT_REPOSITORY https://github.com/google/googletest.git`
	`62`	`+ GIT_TAG release-1.12.1`
`62`	`63`	`)`
`63`	`64`	`# For Windows: Prevent overriding the parent project's compiler/linker settings`
`64`	`65`	`set(gtest_force_shared_crt ON CACHE BOOL "" FORCE)`
`@@ -108,7 +109,7 @@ add_executable(`
`108`	`109`	`)`
`109`	`110`	`target_link_libraries(`
`110`	`111`	`hello_test`
`111`		`- gtest_main`
	`112`	`+ GTest::gtest_main`
`112`	`113`	`)`
`113`	`114`
`114`	`115`	`include(GoogleTest)`