Implement type-refining fragments (fixes #154) #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomhoule
force-pushed
the
type-refining-fragments
branch
from
755c950 to
30a3125
Compare
tomhoule
commented
Nov 2, 2018
graphql_client_codegen/src/unions.rs
Outdated
|
|
||
| Ok(quote! { | ||
| #variant_name(#variant_type) | ||
| }) |
There was a problem hiding this comment.
This needs to be improved before we merge
tomhoule
commented
Nov 2, 2018
| typename_field, | ||
| ]); | ||
|
|
||
| assert_eq!(iface.object_selection(&selection, &context), Selection(vec![])); |
There was a problem hiding this comment.
__typename should probably be included in the object selection.
tomhoule
changed the title
tomhoule
force-pushed
the
type-refining-fragments
branch
from
30a3125 to
d578bfa
Compare
tomhoule
force-pushed
the
type-refining-fragments
branch
from
d578bfa to
e8a1e6d
Compare
tomhoule
force-pushed
the
type-refining-fragments
branch
from
4f2f362 to
3b5022f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.