Skip to content

Commit c318185

Browse files
authored
feat: exporting field and active tab label change (#1309)
* feat: exporting field and active tab label change * refactor: fixing lint errors
1 parent bb43344 commit c318185

File tree

2 files changed

+15
-1
lines changed

2 files changed

+15
-1
lines changed

projects/observability/src/public-api.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,8 @@ export * from './shared/services/entity-breadcrumb/entity-breadcrumb.resolver';
9797
// Span Detail
9898
export { SpanData } from './shared/components/span-detail/span-data';
9999
export { SpanTitle } from './shared/components/span-detail/span-title';
100+
export { SpanDetailTab } from './shared/components/span-detail/span-detail-tab';
101+
100102
export * from './shared/components/span-detail/span-detail.component';
101103
export * from './shared/components/span-detail/span-detail.module';
102104
export { SpanDetailLayoutStyle } from './shared/components/span-detail/span-detail-layout-style';

projects/observability/src/shared/components/span-detail/span-detail.component.ts

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,11 @@ import { SpanDetailTab } from './span-detail-tab';
2424
<ng-content></ng-content>
2525
</div>
2626
27-
<ht-tab-group class="tabs-group" [activeTabLabel]="this.activeTabLabel">
27+
<ht-tab-group
28+
class="tabs-group"
29+
[activeTabLabel]="this.activeTabLabel"
30+
(activeTabLabelChange)="this.onActiveTabLabelChange($event)"
31+
>
2832
<ht-tab label="${SpanDetailTab.Request}" *ngIf="this.showRequestTab">
2933
<ht-span-request-detail
3034
class="request"
@@ -69,6 +73,9 @@ export class SpanDetailComponent implements OnChanges {
6973
@Input()
7074
public activeTabLabel?: SpanDetailTab;
7175

76+
@Output()
77+
private readonly activeTabLabelChange: EventEmitter<SpanDetailTab> = new EventEmitter<SpanDetailTab>();
78+
7279
@Output()
7380
public readonly closed: EventEmitter<void> = new EventEmitter<void>();
7481

@@ -93,4 +100,9 @@ export class SpanDetailComponent implements OnChanges {
93100
this.totalLogEvents = (this.spanData?.logEvents ?? []).length;
94101
}
95102
}
103+
104+
public onActiveTabLabelChange(tabLabel: SpanDetailTab): void {
105+
this.activeTabLabel = tabLabel;
106+
this.activeTabLabelChange.emit(tabLabel);
107+
}
96108
}

0 commit comments

Comments
 (0)