Skip to content

Commit c33d754

Browse files
committed
Merge branch 'main' of github.com:hypertrace/hypertrace-ui into table-filters-highlight-applied
2 parents 88c6643 + 70f6e9a commit c33d754

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

projects/observability/src/shared/components/explore-query-editor/explore-visualization-builder.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ export class ExploreVisualizationBuilder implements OnDestroy {
149149
defaultIfEmpty<AttributeMetadata[]>([]),
150150
map(attributes =>
151151
attributes
152-
.filter(attribute => !attribute.onlySupportsAggregation)
152+
.filter(attribute => !attribute.onlySupportsGrouping)
153153
.map(attribute => this.specBuilder.attributeSpecificationForKey(attribute.name))
154154
),
155155
map(specsFromRequest => uniqBy(specsFromRequest, spec => spec.name))
@@ -205,11 +205,10 @@ export class ExploreVisualizationBuilder implements OnDestroy {
205205
}
206206

207207
private buildDefaultSeries(context: string): ExploreSeries {
208-
const attributeKey = context === SPAN_SCOPE ? 'duration' : 'calls'; // Todo revisit this
209-
const aggregation = context === SPAN_SCOPE ? MetricAggregationType.Average : MetricAggregationType.Count;
208+
const attributeKey = context === SPAN_SCOPE ? 'spans' : 'calls';
210209

211210
return {
212-
specification: this.exploreSpecBuilder.exploreSpecificationForKey(attributeKey, aggregation),
211+
specification: this.exploreSpecBuilder.exploreSpecificationForKey(attributeKey, MetricAggregationType.Count),
213212
visualizationOptions: {
214213
type: CartesianSeriesVisualizationType.Column
215214
}

0 commit comments

Comments
 (0)