Skip to content

Commit 03ebe32

Browse files
IlanTruanovskypcolberg
authored andcommitted
Fix RESOURCE_LEAK error in acl_profiler_test.cpp
Coverity picked up a `RESOURCE_LEAK` error that was not fixed in #267 Fixes: ``` test/acl_profiler_test.cpp:812:3: Type: Resource leak (RESOURCE_LEAK) test/acl_profiler_test.cpp:756:3: 1. path: Condition "MtUtest::threadNum() == 0", taking true branch. test/acl_profiler_test.cpp:758:5: 2. path: Condition "0 != status", taking true branch. test/acl_profiler_test.cpp:758:5: 3. path: Falling through to end of if statement. test/acl_profiler_test.cpp:763:5: 4. path: Condition "0 != status", taking true branch. test/acl_profiler_test.cpp:763:5: 5. path: Falling through to end of if statement. test/acl_profiler_test.cpp:765:5: 6. path: Condition "0 != clSetKernelArg(kernel, 0, 8UL /* sizeof (cl_mem) */, &src_mem)", taking true branch. test/acl_profiler_test.cpp:765:5: 7. path: Falling through to end of if statement. test/acl_profiler_test.cpp:767:5: 8. path: Condition "0 != clSetKernelArg(kernel, 1, 8UL /* sizeof (cl_mem) */, &src_mem)", taking true branch. test/acl_profiler_test.cpp:767:5: 9. path: Falling through to end of if statement. test/acl_profiler_test.cpp:769:5: 10. path: Condition "0 != clSetKernelArg(kernel, 2, 8UL /* sizeof (cl_mem) */, &src_mem)", taking true branch. test/acl_profiler_test.cpp:769:5: 11. path: Falling through to end of if statement. test/acl_profiler_test.cpp:777:5: 12. path: Condition "0 != status", taking true branch. test/acl_profiler_test.cpp:777:5: 13. path: Falling through to end of if statement. test/acl_profiler_test.cpp:784:3: 14. path: Condition "MtUtest::threadNum() == 0", taking true branch. test/acl_profiler_test.cpp:786:5: 15. path: Condition "active_op", taking true branch. test/acl_profiler_test.cpp:786:5: 16. path: Condition "!Utest::getCurrent()->assertTrue(active_op, "active_op", "/__w/fpga-runtime-for-opencl/fpga-runtime-for-opencl/test/acl_profiler_test.cpp", 786)", taking true branch. test/acl_profiler_test.cpp:787:5: 17. path: Condition "ACL_DEVICE_OP_KERNEL != active_op->info.type", taking true branch. test/acl_profiler_test.cpp:787:5: 18. path: Falling through to end of if statement. test/acl_profiler_test.cpp:796:3: 19. path: Condition "MtUtest::threadNum() == 0", taking true branch. test/acl_profiler_test.cpp:797:5: 20. alloc_fn: Storage is returned from allocation function "fopen". test/acl_profiler_test.cpp:797:5: 21. var_assign: Assigning: "fp" = storage returned from "fopen("profile.mon", "r")". test/acl_profiler_test.cpp:798:5: 22. path: Condition "fp == NULL", taking false branch. test/acl_profiler_test.cpp:798:5: 23. path: Condition "!Utest::getCurrent()->assertTrue(fp == NULL, "fp == NULL", "/__w/fpga-runtime-for-opencl/fpga-runtime-for-opencl/test/acl_profiler_test.cpp", 798)", taking true branch. test/acl_profiler_test.cpp:805:5: 24. path: Condition "acl_process_profiler_scan_chain(event->current_device_op)", taking true branch. test/acl_profiler_test.cpp:805:5: 25. path: Condition "!Utest::getCurrent()->assertTrue(acl_process_profiler_scan_chain(event->current_device_op), "acl_process_profiler_scan_chain(event->current_device_op)", "/__w/fpga-runtime-for-opencl/fpga-runtime-for-opencl/test/acl_profiler_test.cpp", 806)", taking true branch. test/acl_profiler_test.cpp:807:5: 26. path: Condition "acl_process_autorun_profiler_scan_chain(0, 0)", taking true branch. test/acl_profiler_test.cpp:807:5: 27. path: Condition "!Utest::getCurrent()->assertTrue(acl_process_autorun_profiler_scan_chain(0, 0), "acl_process_autorun_profiler_scan_chain(0, 0)", "/__w/fpga-runtime-for-opencl/fpga-runtime-for-opencl/test/acl_profiler_test.cpp", 807)", taking true branch. test/acl_profiler_test.cpp:812:3: 28. leaked_storage: Variable "fp" going out of scope leaks the storage it points to. ```
1 parent 2aa5d9e commit 03ebe32

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

test/acl_profiler_test.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -795,6 +795,9 @@ MT_TEST(acl_no_profile, no_profiler) {
795795

796796
if (threadNum() == 0) {
797797
FILE *fp = fopen(PROFILE_MON, "r");
798+
if (fp != NULL) {
799+
fclose(fp);
800+
}
798801
CHECK(fp == NULL);
799802

800803
// Check that the low level call checks event completion status.

0 commit comments

Comments
 (0)