Skip to content

Commit 064ce87

Browse files
committed
Fixed coverity issue in acl_kernel_if.cpp: Type: Invalid type in argument to printf format specifier (PRINTF_ARGS)
1 parent f8e3a83 commit 064ce87

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

src/acl_kernel_if.cpp

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ static int get_auto_discovery_string(acl_kernel_if *kern, char *config_str) {
247247
kern->io.printf(" HAL Kern: Version ID incorrect\n");
248248
return -1;
249249
}
250-
ACL_KERNEL_IF_DEBUG_MSG(kern, "Read %d bytes from kernel auto discovery", r);
250+
ACL_KERNEL_IF_DEBUG_MSG(kern, "Read %zu bytes from kernel auto discovery", r);
251251

252252
return (r == rom_size) ? 0 : -1;
253253
}
@@ -288,7 +288,7 @@ static int acl_kernel_if_read_32b(acl_kernel_if *kern, unsigned int addr,
288288
r = kern->io.read(&kern->io, (dev_addr_t)addr, (char *)val, (size_t)size);
289289
if (r < size) {
290290
kern->io.printf(
291-
"HAL Kern Error: Read failed from addr %x, read %d expected %d\n", addr,
291+
"HAL Kern Error: Read failed from addr %x, read %zu expected %zu\n", addr,
292292
r, size);
293293
return -1;
294294
}
@@ -334,7 +334,7 @@ static int acl_kernel_rom_read_block(acl_kernel_if *kern, unsigned int addr,
334334
r = kern->io.read(&kern->io, (dev_addr_t)addr, config_rom, (size_t)size);
335335
if (r < size) {
336336
kern->io.printf(
337-
"HAL Kern Error: Read failed from addr %x, read %d expected %d\n", addr,
337+
"HAL Kern Error: Read failed from addr %x, read %zu expected %zu\n", addr,
338338
r, size);
339339
return -1;
340340
}
@@ -381,7 +381,7 @@ static int acl_kernel_if_write_64b(acl_kernel_if *kern, unsigned int addr,
381381
r = (int)kern->io.write(&kern->io, (dev_addr_t)addr, (char *)&val,
382382
(size_t)size);
383383
if (r < size) {
384-
kern->io.printf("HAL Kern Error: Write failed to addr %x with value %x, "
384+
kern->io.printf("HAL Kern Error: Write failed to addr %x with value %zu, "
385385
"wrote %d, expected %d\n",
386386
addr, val, r, size);
387387
return -1;
@@ -423,8 +423,8 @@ static int acl_kernel_if_write_block(acl_kernel_if *kern, unsigned int addr,
423423

424424
if (r < aligned_size) {
425425
kern->io.printf("HAL Kern Error: Write failed to addr %x with value %x, "
426-
"wrote %d expected %d\n",
427-
addr, val, r, aligned_size);
426+
"wrote %zu expected %zu\n",
427+
addr, *val, r, aligned_size);
428428
return -1;
429429
}
430430
return 0;
@@ -930,7 +930,7 @@ int acl_kernel_if_update(const acl_device_def_autodiscovery_t &devdef,
930930
OFFSET_KERNEL_CRA + devdef.hal_info[ii].csr.address;
931931
kern->accel_csr[ii].bytes = devdef.hal_info[ii].csr.num_bytes;
932932

933-
ACL_KERNEL_IF_DEBUG_MSG(kern, "Kernel_%s CSR { 0x%08x, 0x%08x }\n",
933+
ACL_KERNEL_IF_DEBUG_MSG(kern, "Kernel_%s CSR { 0x%08zu, 0x%08zu }\n",
934934
devdef.accel[ii].iface.name.c_str(),
935935
kern->accel_csr[ii].address,
936936
kern->accel_csr[ii].bytes);
@@ -942,7 +942,7 @@ int acl_kernel_if_update(const acl_device_def_autodiscovery_t &devdef,
942942
OFFSET_KERNEL_CRA + devdef.hal_info[ii].perf_mon.address;
943943
kern->accel_perf_mon[ii].bytes = devdef.hal_info[ii].perf_mon.num_bytes;
944944

945-
ACL_KERNEL_IF_DEBUG_MSG(kern, "Kernel_%s perf_mon { 0x%08x, 0x%08x }\n",
945+
ACL_KERNEL_IF_DEBUG_MSG(kern, "Kernel_%s perf_mon { 0x%08zu, 0x%08zu }\n",
946946
devdef.accel[ii].iface.name.c_str(),
947947
kern->accel_perf_mon[ii].address,
948948
kern->accel_perf_mon[ii].bytes);
@@ -1056,7 +1056,7 @@ int acl_kernel_if_post_pll_config_init(acl_kernel_if *kern) {
10561056
kern->csr_version = version;
10571057
ACL_KERNEL_IF_DEBUG_MSG(kern,
10581058
"Read CSR version from kernel 0: Version = %u\n",
1059-
kern->csr_version);
1059+
kern->csr_version.value());
10601060
if (kern->csr_version < 5) {
10611061
// Register addresses are pushed back since previous versions
10621062
// doesn't have the start register
@@ -1190,7 +1190,7 @@ void acl_kernel_if_launch_kernel_on_custom_sof(
11901190
kern->io.printf(" currently in use, OR\n");
11911191
kern->io.printf(" b) The host can not communicate properly with the "
11921192
"compiled kernel.\n");
1193-
kern->io.printf("Saw version=%u, expected=%u.\n", kern->csr_version,
1193+
kern->io.printf("Saw version=%u, expected=%u.\n", kern->csr_version.value(),
11941194
CSR_VERSION_ID);
11951195
assert(0); // Assert here because no way to pass an error up to the user.
11961196
// clEnqueue has already returned.
@@ -1885,7 +1885,7 @@ int acl_kernel_if_get_profile_data(acl_kernel_if *kern, cl_uint accel_id,
18851885
data[i] = acl_kernel_if_get_profile_data_word(kern, accel_id);
18861886
ACL_KERNEL_IF_DEBUG_MSG(kern,
18871887
":: Read profile hardware:: Accelerator %d "
1888-
"profile_data word [%u] is 0x%016llx.\n",
1888+
"profile_data word [%zu] is 0x%016llx.\n",
18891889
accel_id, i, data[i]);
18901890
}
18911891

0 commit comments

Comments
 (0)