You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Coverity complains that some setup functions' return values are not being checked. I chose to ignore the return values of these functions.
I tried adding a CHECK(...) to check for success, but this caused a function in Utest.cpp to seg fault. I'm assuming this is caused due to some CPPuTest things variables/methods not being initialized until after the problematic `acl_test.cpp` function is called.
I think it is better to just ignore the function call's return valueand if it fails, the test that called the initialization function(s) will fail.
Fixes:
```
test/acl_test.cpp:95:3:
Type: Unchecked return value (CHECKED_RETURN)
test/acl_test.cpp:95:3: Unchecked call to function
1. check_return: Calling "acl_set_hal" without checking return value (as is done elsewhere 28 out of 31 times).
src/acl_globals.cpp:182:3: Examples where return value from this function is checked
2. example_checked: Example 1: "acl_set_hal(board_hal)" has its value checked in "acl_set_hal(board_hal)".
test/acl_globals_test.cpp:697:1: Examples where return value from this function is checked
3. example_checked: Example 2: "acl_set_hal(acl_test_get_simple_hal())" has its value checked in "acl_set_hal(acl_test_get_simple_hal())".
test/acl_hal_test.cpp:303:3: Examples where return value from this function is checked
4. example_checked: Example 3: "acl_set_hal(&simple_hal)" has its value checked in "acl_set_hal(&simple_hal)".
test/acl_hal_test.cpp:181:3: Examples where return value from this function is checked
5. example_checked: Example 4: "acl_set_hal(&simple_hal)" has its value checked in "1 == acl_set_hal(&simple_hal)".
test/acl_hal_test.cpp:232:3: Examples where return value from this function is checked
6. example_checked: Example 5: "acl_set_hal(&bad_hal)" has its value checked in "0 == acl_set_hal(&bad_hal)".
test/acl_test.cpp:102:3:
Type: Unchecked return value (CHECKED_RETURN)
test/acl_test.cpp:102:3: Unchecked call to function
1. check_return: Calling "acl_set_hal" without checking return value (as is done elsewhere 28 out of 31 times).
src/acl_globals.cpp:182:3: Examples where return value from this function is checked
2. example_checked: Example 1: "acl_set_hal(board_hal)" has its value checked in "acl_set_hal(board_hal)".
test/acl_globals_test.cpp:697:1: Examples where return value from this function is checked
3. example_checked: Example 2: "acl_set_hal(acl_test_get_simple_hal())" has its value checked in "acl_set_hal(acl_test_get_simple_hal())".
test/acl_hal_test.cpp:303:3: Examples where return value from this function is checked
4. example_checked: Example 3: "acl_set_hal(&simple_hal)" has its value checked in "acl_set_hal(&simple_hal)".
test/acl_hal_test.cpp:181:3: Examples where return value from this function is checked
5. example_checked: Example 4: "acl_set_hal(&simple_hal)" has its value checked in "1 == acl_set_hal(&simple_hal)".
test/acl_hal_test.cpp:232:3: Examples where return value from this function is checked
6. example_checked: Example 5: "acl_set_hal(&bad_hal)" has its value checked in "0 == acl_set_hal(&bad_hal)".
test/acl_test.cpp:109:3:
Type: Unchecked return value (CHECKED_RETURN)
test/acl_test.cpp:109:3: Unchecked call to function
1. check_return: Calling "acl_set_hal" without checking return value (as is done elsewhere 28 out of 31 times).
src/acl_globals.cpp:182:3: Examples where return value from this function is checked
2. example_checked: Example 1: "acl_set_hal(board_hal)" has its value checked in "acl_set_hal(board_hal)".
test/acl_globals_test.cpp:697:1: Examples where return value from this function is checked
3. example_checked: Example 2: "acl_set_hal(acl_test_get_simple_hal())" has its value checked in "acl_set_hal(acl_test_get_simple_hal())".
test/acl_hal_test.cpp:303:3: Examples where return value from this function is checked
4. example_checked: Example 3: "acl_set_hal(&simple_hal)" has its value checked in "acl_set_hal(&simple_hal)".
test/acl_hal_test.cpp:181:3: Examples where return value from this function is checked
5. example_checked: Example 4: "acl_set_hal(&simple_hal)" has its value checked in "1 == acl_set_hal(&simple_hal)".
test/acl_hal_test.cpp:232:3: Examples where return value from this function is checked
6. example_checked: Example 5: "acl_set_hal(&bad_hal)" has its value checked in "0 == acl_set_hal(&bad_hal)".
```
0 commit comments